Introduce font.line_height #1430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hummer12007
force-pushed
the
line-height
branch
3 times, most recently
from
cfe11eb to
32dd7c8
Compare
Contributor
Author
|
Want to wire it up in a few more places. |
Hummer12007
force-pushed
the
line-height
branch
from
32dd7c8 to
889cc21
Compare
Hummer12007
force-pushed
the
line-height
branch
4 times, most recently
from
17cb58c to
7c07e32
Compare
casperstorm
reviewed
Feb 6, 2026
Member
casperstorm
left a comment
casperstorm
left a comment
There was a problem hiding this comment.
I feel like we should make a a new text() inside perhaps src/widget which simplifies text(content).line_height(theme::line_height(&config.font)) a bit - its quite a long write.
Hummer12007
force-pushed
the
line-height
branch
from
ca19f38 to
cd86cc8
Compare
casperstorm
force-pushed
the
line-height
branch
from
33f11f6 to
d46b3b2
Compare
Hummer12007
force-pushed
the
line-height
branch
from
d46b3b2 to
b47c4d7
Compare
casperstorm
approved these changes
Feb 10, 2026
Hummer12007
force-pushed
the
line-height
branch
from
b47c4d7 to
4c9e586
Compare
casperstorm
force-pushed
the
line-height
branch
from
4c9e586 to
ed995d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the font.line_height config value.
Wire it up for all text in the main interface. It probably doesn't matter that much for other views but idk.
Also two minor refactorings to make the commits nice and clean.