alert-mgmt-12: PATCH /rules bulk update handler#11
Open
sradco wants to merge 1 commit intoalert-mgmt-11-platform-updatefrom
Open
alert-mgmt-12: PATCH /rules bulk update handler#11sradco wants to merge 1 commit intoalert-mgmt-11-platform-updatefrom
sradco wants to merge 1 commit intoalert-mgmt-11-platform-updatefrom
Conversation
sradco
force-pushed
the
alert-mgmt-11-platform-update
branch
from
79de5cb to
0e38ca2
Compare
sradco
force-pushed
the
alert-mgmt-12-bulk-update-handler
branch
from
e36d25b to
856bbfd
Compare
sradco
force-pushed
the
alert-mgmt-11-platform-update
branch
from
0e38ca2 to
4e064d9
Compare
sradco
force-pushed
the
alert-mgmt-12-bulk-update-handler
branch
from
856bbfd to
e1a7bdb
Compare
sradco
force-pushed
the
alert-mgmt-11-platform-update
branch
from
4e064d9 to
aa28a8b
Compare
sradco
force-pushed
the
alert-mgmt-12-bulk-update-handler
branch
from
e1a7bdb to
c55d856
Compare
sradco
force-pushed
the
alert-mgmt-11-platform-update
branch
from
aa28a8b to
fb62715
Compare
sradco
force-pushed
the
alert-mgmt-12-bulk-update-handler
branch
from
c55d856 to
2325e45
Compare
sradco
force-pushed
the
alert-mgmt-11-platform-update
branch
from
fb62715 to
9cd4085
Compare
sradco
force-pushed
the
alert-mgmt-12-bulk-update-handler
branch
from
2325e45 to
018ba46
Compare
sradco
force-pushed
the
alert-mgmt-11-platform-update
branch
from
9cd4085 to
3cfe659
Compare
sradco
force-pushed
the
alert-mgmt-12-bulk-update-handler
branch
from
018ba46 to
204f240
Compare
sradco
force-pushed
the
alert-mgmt-11-platform-update
branch
from
3cfe659 to
88846bb
Compare
sradco
force-pushed
the
alert-mgmt-12-bulk-update-handler
branch
from
204f240 to
05e7db5
Compare
sradco
force-pushed
the
alert-mgmt-11-platform-update
branch
from
88846bb to
b85c592
Compare
sradco
force-pushed
the
alert-mgmt-12-bulk-update-handler
branch
from
05e7db5 to
0b77990
Compare
sradco
force-pushed
the
alert-mgmt-11-platform-update
branch
from
b85c592 to
6f6cc32
Compare
sradco
force-pushed
the
alert-mgmt-12-bulk-update-handler
branch
from
0b77990 to
5cfb683
Compare
sradco
force-pushed
the
alert-mgmt-11-platform-update
branch
from
6f6cc32 to
5a9f130
Compare
sradco
force-pushed
the
alert-mgmt-12-bulk-update-handler
branch
from
5cfb683 to
6897d28
Compare
sradco
force-pushed
the
alert-mgmt-11-platform-update
branch
from
5a9f130 to
8302351
Compare
sradco
force-pushed
the
alert-mgmt-12-bulk-update-handler
branch
from
6897d28 to
96629ef
Compare
sradco
force-pushed
the
alert-mgmt-11-platform-update
branch
from
8302351 to
09cf93a
Compare
sradco
force-pushed
the
alert-mgmt-12-bulk-update-handler
branch
from
96629ef to
f595203
Compare
sradco
force-pushed
the
alert-mgmt-11-platform-update
branch
from
09cf93a to
427d5b2
Compare
sradco
force-pushed
the
alert-mgmt-12-bulk-update-handler
branch
from
f595203 to
51af654
Compare
sradco
force-pushed
the
alert-mgmt-11-platform-update
branch
from
427d5b2 to
f727831
Compare
sradco
force-pushed
the
alert-mgmt-12-bulk-update-handler
branch
2 times, most recently
from
5d1c269 to
29f0dfc
Compare
sradco
force-pushed
the
alert-mgmt-11-platform-update
branch
from
f727831 to
e85cd17
Compare
sradco
force-pushed
the
alert-mgmt-12-bulk-update-handler
branch
2 times, most recently
from
8869060 to
cfd5ea0
Compare
sradco
force-pushed
the
alert-mgmt-11-platform-update
branch
from
083f542 to
4953fea
Compare
sradco
force-pushed
the
alert-mgmt-12-bulk-update-handler
branch
from
cfd5ea0 to
d814f31
Compare
sradco
force-pushed
the
alert-mgmt-11-platform-update
branch
from
6b25100 to
e020fed
Compare
sradco
force-pushed
the
alert-mgmt-12-bulk-update-handler
branch
from
d814f31 to
7d1dbf0
Compare
Signed-off-by: Shirly Radco <sradco@redhat.com> Signed-off-by: João Vilaça <jvilaca@redhat.com> Signed-off-by: Aviv Litman <alitman@redhat.com> Co-authored-by: AI Assistant <noreply@cursor.com>
sradco
force-pushed
the
alert-mgmt-12-bulk-update-handler
branch
from
7d1dbf0 to
6527edb
Compare
sradco
force-pushed
the
alert-mgmt-11-platform-update
branch
from
e020fed to
beb842b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alert Management API — Part 12/14: user-defined update + PATCH /rules (bulk)
Summary
PATCH /api/v1/alerting/rulesbulk handler: acceptsruleIdsarray with label changes, drop/restore toggle, and classification patchUpdateUserDefinedAlertRule: validates preconditions, updates PrometheusRule spec in-place, handles rule ID changes by migrating classification overridesNotAllowedErrorGetRuleById, merges with requested label set/unset operationsUpdateAlertRuleResponsetype (also used by single-rule update in PR 14)Dependencies
This PR is part of a stacked series. Please review in order.
2–11. Pending — alert queries, relabel/health, management foundation, endpoints, create, delete, classification, platform update
13–14. Pending — docs/CI/e2e, single-rule API