Fix running play-mode tests in player#673
Open
haraldreingruber wants to merge 1 commit intossannandeji:masterfrom
Open
Fix running play-mode tests in player#673haraldreingruber wants to merge 1 commit intossannandeji:masterfrom
haraldreingruber wants to merge 1 commit intossannandeji:masterfrom
Conversation
I was not able to run play-mode tests using the Zenject.SceneTestFixture in a player (instead of in the Editor) until I removed the restriction to the Editor platform for the Zenject-TestFramework asmdef. It makes kind of sense, as it will be running on other platforms, not in the Editor. I guess the reason for having it there is to prevent Unity from including the test framework in the actual builds. I think this can be acheived as well with adding the "UNITY_INCLUDE_TESTS" constraint. Could you double-check if that works for you?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was not able to run play-mode tests using the Zenject.SceneTestFixture in a player (instead of in the Editor) until I removed the restriction to the Editor platform for the Zenject-TestFramework asmdef. It makes kind of sense, as it will be running on other platforms, not in the Editor.
I guess the reason for having it there is to prevent Unity from including the test framework in the actual builds. I think this can be achieved as well by adding the "UNITY_INCLUDE_TESTS" constraint. Could you double-check if that works for you?