Skip to content

Comments

chore: fix eip1271 ABI#209

Open
MatusKysel wants to merge 1 commit intounstablefrom
fix-eip1271
Open

chore: fix eip1271 ABI#209
MatusKysel wants to merge 1 commit intounstablefrom
fix-eip1271

Conversation

@MatusKysel
Copy link
Contributor

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates network handling to use new eth2-key-manager-core APIs, enhances error handling for network parsing, and bumps related dependencies.

  • Replace spec_crypto.GetNetworkByFork with NetworkFromForkVersion from eth2-key-manager-core
  • Improve error handling for NetworkFromString in tests and CLI commands
  • Bump Go toolchain and eth2-key-manager/dkg-spec module versions

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pkgs/initiator/initiator_test.go Capture fork with error handling instead of inline call
pkgs/initiator/initiator.go Use NetworkFromForkVersion from key-manager-core
pkgs/crypto/deposit_data.go Alias import and update calls to NetworkFromForkVersion
go.mod Update Go toolchain, bump dkg-spec and eth2-key-manager
cli/initiator/*.go Standardize NetworkFromString error handling in CLI commands
Comments suppressed due to low confidence (2)

pkgs/initiator/initiator.go:600

  • [nitpick] The import alias eth2_key_manager_core is inconsistent with other files that use e2m_core; consider using a single, consistent alias for readability.
	network, err := eth2_key_manager_core.NetworkFromForkVersion(fork)

cli/initiator/initiator.go:66

  • There's no test covering the error path when an invalid network is provided; consider adding a test to ensure proper error handling for bad --network inputs.
		ethNetwork, err := e2m_core.NetworkFromString(flags.Network)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants