Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates network handling to use new eth2-key-manager-core APIs, enhances error handling for network parsing, and bumps related dependencies.
- Replace
spec_crypto.GetNetworkByForkwithNetworkFromForkVersionfrometh2-key-manager-core - Improve error handling for
NetworkFromStringin tests and CLI commands - Bump Go toolchain and
eth2-key-manager/dkg-specmodule versions
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkgs/initiator/initiator_test.go | Capture fork with error handling instead of inline call |
| pkgs/initiator/initiator.go | Use NetworkFromForkVersion from key-manager-core |
| pkgs/crypto/deposit_data.go | Alias import and update calls to NetworkFromForkVersion |
| go.mod | Update Go toolchain, bump dkg-spec and eth2-key-manager |
| cli/initiator/*.go | Standardize NetworkFromString error handling in CLI commands |
Comments suppressed due to low confidence (2)
pkgs/initiator/initiator.go:600
- [nitpick] The import alias
eth2_key_manager_coreis inconsistent with other files that usee2m_core; consider using a single, consistent alias for readability.
network, err := eth2_key_manager_core.NetworkFromForkVersion(fork)
cli/initiator/initiator.go:66
- There's no test covering the error path when an invalid network is provided; consider adding a test to ensure proper error handling for bad
--networkinputs.
ethNetwork, err := e2m_core.NetworkFromString(flags.Network)
alan-ssvlabs
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.