Open
Conversation
Contributor
Mohsen-T
commented
Feb 12, 2024
Mohsen-T
commented
- refactored the skip files array generation process in the .solcover.js
- solidity-coverage does not offer native support *.sol.
- implemented a programmatic function to dynamically generate the skip files array based on folder names.
- defined the depth of coverage
Enhanced test coverage by incorporating additional test cases to address previously overlooked scenarios
…into bulk-features
- refactored the skip files array generation process in the .solcover.js - solidity-coverage does not offer native support *.sol. - implemented a programmatic function to dynamically generate the skip files array based on folder names. - defined the depth of coverage
Contributor
@Mohsen-T
to reach this point, create a test in `test/validators/remove.ts` trying to remove an existing validator (`publicKey` correct) with the wrong parameters (`msg.sender` or `operatorIds`)
|
Contributor
@Mohsen-T please create a test to fire the revert PublicKeysSharesLengthMismatch |
Contributor
In ClusterLib.sol seems this line is skipped. |
Contributor
In OperatorsLib.sol, we haven't tested |
Contributor
ProtocolLib.sol
Please test the `MaxValueExceeded` error
|
Contributor
|
Contributor
please skip |
mtabasco
requested changes
Feb 14, 2024
Contributor
mtabasco
left a comment
mtabasco
left a comment
There was a problem hiding this comment.
Please see the attached comments. thanks
mtabasco
approved these changes
Feb 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.