-
Notifications
You must be signed in to change notification settings - Fork 58
Upgrade contract to increase max validators #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mtabasco
wants to merge
6
commits into
main
Choose a base branch
from
upgrade-max-validators
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
db22ecb
mekong stage deployment
mtabasco bbfb3a5
Upgrade max validators per operator
mtabasco 008f675
fix upgrade
mtabasco fcec451
main oz json post upgrade
a1dc3a9
remove holesky references, upgrade hardhat
mtabasco 2859419
remove scripts
mtabasco File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,260 @@ | ||
| { | ||
| "manifestVersion": "3.2", | ||
| "proxies": [ | ||
| { | ||
| "address": "0x8383d719377047b1B8824CbB7f8ba7f24F12c715", | ||
| "txHash": "0x5e94298fc1601fc494e433477c01205c8952ad9c1cb5aa0296a80e47963b28f6", | ||
| "kind": "uups" | ||
| }, | ||
| { | ||
| "address": "0x2196C292d792d235b21b00E9e8c39BcE5404007C", | ||
| "txHash": "0x1bb4f354e955dc2da5384170bc8a864b88bb444ce4707c879441497cdcd2bbab", | ||
| "kind": "uups" | ||
| }, | ||
| { | ||
| "address": "0xF73487805D2954284AA69a8E3797105c4c0b050B", | ||
| "txHash": "0x7b4134fd1a9eafa712ab799b2d63b95cff2dea6ed4124f07e3ba96f2757bdf43", | ||
| "kind": "uups" | ||
| } | ||
| ], | ||
| "impls": { | ||
| "350f8e1c7a01c817bb83103cd78dcb1d0b3510b15601eff2bea87d6506ccd751": { | ||
| "address": "0x58EabC62cC2c254AC43E35Edbb0D1f74f3DAd508", | ||
| "txHash": "0x6b75f46cd5affb8b348f6ca81028810731cfc155ce593070774f0cb6b6dbabc0", | ||
| "layout": { | ||
| "solcVersion": "0.8.24", | ||
| "storage": [ | ||
| { | ||
| "label": "_initialized", | ||
| "offset": 0, | ||
| "slot": "0", | ||
| "type": "t_uint8", | ||
| "contract": "Initializable", | ||
| "src": "@openzeppelin/contracts-upgradeable/proxy/utils/Initializable.sol:63", | ||
| "retypedFrom": "bool" | ||
| }, | ||
| { | ||
| "label": "_initializing", | ||
| "offset": 1, | ||
| "slot": "0", | ||
| "type": "t_bool", | ||
| "contract": "Initializable", | ||
| "src": "@openzeppelin/contracts-upgradeable/proxy/utils/Initializable.sol:68" | ||
| }, | ||
| { | ||
| "label": "__gap", | ||
| "offset": 0, | ||
| "slot": "1", | ||
| "type": "t_array(t_uint256)50_storage", | ||
| "contract": "ERC1967UpgradeUpgradeable", | ||
| "src": "@openzeppelin/contracts-upgradeable/proxy/ERC1967/ERC1967UpgradeUpgradeable.sol:169" | ||
| }, | ||
| { | ||
| "label": "__gap", | ||
| "offset": 0, | ||
| "slot": "51", | ||
| "type": "t_array(t_uint256)50_storage", | ||
| "contract": "UUPSUpgradeable", | ||
| "src": "@openzeppelin/contracts-upgradeable/proxy/utils/UUPSUpgradeable.sol:111" | ||
| }, | ||
| { | ||
| "label": "__gap", | ||
| "offset": 0, | ||
| "slot": "101", | ||
| "type": "t_array(t_uint256)50_storage", | ||
| "contract": "ContextUpgradeable", | ||
| "src": "@openzeppelin/contracts-upgradeable/utils/ContextUpgradeable.sol:40" | ||
| }, | ||
| { | ||
| "label": "_owner", | ||
| "offset": 0, | ||
| "slot": "151", | ||
| "type": "t_address", | ||
| "contract": "OwnableUpgradeable", | ||
| "src": "@openzeppelin/contracts-upgradeable/access/OwnableUpgradeable.sol:22" | ||
| }, | ||
| { | ||
| "label": "__gap", | ||
| "offset": 0, | ||
| "slot": "152", | ||
| "type": "t_array(t_uint256)49_storage", | ||
| "contract": "OwnableUpgradeable", | ||
| "src": "@openzeppelin/contracts-upgradeable/access/OwnableUpgradeable.sol:94" | ||
| }, | ||
| { | ||
| "label": "_pendingOwner", | ||
| "offset": 0, | ||
| "slot": "201", | ||
| "type": "t_address", | ||
| "contract": "Ownable2StepUpgradeable", | ||
| "src": "@openzeppelin/contracts-upgradeable/access/Ownable2StepUpgradeable.sol:21" | ||
| }, | ||
| { | ||
| "label": "__gap", | ||
| "offset": 0, | ||
| "slot": "202", | ||
| "type": "t_array(t_uint256)49_storage", | ||
| "contract": "Ownable2StepUpgradeable", | ||
| "src": "@openzeppelin/contracts-upgradeable/access/Ownable2StepUpgradeable.sol:70" | ||
| } | ||
| ], | ||
| "types": { | ||
| "t_address": { | ||
| "label": "address", | ||
| "numberOfBytes": "20" | ||
| }, | ||
| "t_array(t_uint256)49_storage": { | ||
| "label": "uint256[49]", | ||
| "numberOfBytes": "1568" | ||
| }, | ||
| "t_array(t_uint256)50_storage": { | ||
| "label": "uint256[50]", | ||
| "numberOfBytes": "1600" | ||
| }, | ||
| "t_bool": { | ||
| "label": "bool", | ||
| "numberOfBytes": "1" | ||
| }, | ||
| "t_uint256": { | ||
| "label": "uint256", | ||
| "numberOfBytes": "32" | ||
| }, | ||
| "t_uint8": { | ||
| "label": "uint8", | ||
| "numberOfBytes": "1" | ||
| } | ||
| }, | ||
| "namespaces": {} | ||
| } | ||
| }, | ||
| "da06f711e239a6b927747cdeefb5954a754f3a4e01a17212488672f6689ac6f1": { | ||
| "address": "0x9B1AeF6E0d3C2063D45Ff2Cc04c1B8ee1B66f640", | ||
| "txHash": "0xacb2a040e9d61c5c9978b06ce62ec9f4cd1866c4326cd3f632e98b8c04e3eaa4", | ||
| "layout": { | ||
| "solcVersion": "0.8.24", | ||
| "storage": [ | ||
| { | ||
| "label": "_initialized", | ||
| "offset": 0, | ||
| "slot": "0", | ||
| "type": "t_uint8", | ||
| "contract": "Initializable", | ||
| "src": "@openzeppelin/contracts-upgradeable/proxy/utils/Initializable.sol:63", | ||
| "retypedFrom": "bool" | ||
| }, | ||
| { | ||
| "label": "_initializing", | ||
| "offset": 1, | ||
| "slot": "0", | ||
| "type": "t_bool", | ||
| "contract": "Initializable", | ||
| "src": "@openzeppelin/contracts-upgradeable/proxy/utils/Initializable.sol:68" | ||
| }, | ||
| { | ||
| "label": "__gap", | ||
| "offset": 0, | ||
| "slot": "1", | ||
| "type": "t_array(t_uint256)50_storage", | ||
| "contract": "ERC1967UpgradeUpgradeable", | ||
| "src": "@openzeppelin/contracts-upgradeable/proxy/ERC1967/ERC1967UpgradeUpgradeable.sol:169" | ||
| }, | ||
| { | ||
| "label": "__gap", | ||
| "offset": 0, | ||
| "slot": "51", | ||
| "type": "t_array(t_uint256)50_storage", | ||
| "contract": "UUPSUpgradeable", | ||
| "src": "@openzeppelin/contracts-upgradeable/proxy/utils/UUPSUpgradeable.sol:111" | ||
| }, | ||
| { | ||
| "label": "__gap", | ||
| "offset": 0, | ||
| "slot": "101", | ||
| "type": "t_array(t_uint256)50_storage", | ||
| "contract": "ContextUpgradeable", | ||
| "src": "@openzeppelin/contracts-upgradeable/utils/ContextUpgradeable.sol:40" | ||
| }, | ||
| { | ||
| "label": "_owner", | ||
| "offset": 0, | ||
| "slot": "151", | ||
| "type": "t_address", | ||
| "contract": "OwnableUpgradeable", | ||
| "src": "@openzeppelin/contracts-upgradeable/access/OwnableUpgradeable.sol:22" | ||
| }, | ||
| { | ||
| "label": "__gap", | ||
| "offset": 0, | ||
| "slot": "152", | ||
| "type": "t_array(t_uint256)49_storage", | ||
| "contract": "OwnableUpgradeable", | ||
| "src": "@openzeppelin/contracts-upgradeable/access/OwnableUpgradeable.sol:94" | ||
| }, | ||
| { | ||
| "label": "_pendingOwner", | ||
| "offset": 0, | ||
| "slot": "201", | ||
| "type": "t_address", | ||
| "contract": "Ownable2StepUpgradeable", | ||
| "src": "@openzeppelin/contracts-upgradeable/access/Ownable2StepUpgradeable.sol:21" | ||
| }, | ||
| { | ||
| "label": "__gap", | ||
| "offset": 0, | ||
| "slot": "202", | ||
| "type": "t_array(t_uint256)49_storage", | ||
| "contract": "Ownable2StepUpgradeable", | ||
| "src": "@openzeppelin/contracts-upgradeable/access/Ownable2StepUpgradeable.sol:70" | ||
| }, | ||
| { | ||
| "label": "ssvNetwork", | ||
| "offset": 0, | ||
| "slot": "251", | ||
| "type": "t_contract(ISSVViews)4950", | ||
| "contract": "SSVNetworkViews", | ||
| "src": "contracts/SSVNetworkViews.sol:19" | ||
| }, | ||
| { | ||
| "label": "__gap", | ||
| "offset": 0, | ||
| "slot": "252", | ||
| "type": "t_array(t_uint256)50_storage", | ||
| "contract": "SSVNetworkViews", | ||
| "src": "contracts/SSVNetworkViews.sol:23" | ||
| } | ||
| ], | ||
| "types": { | ||
| "t_address": { | ||
| "label": "address", | ||
| "numberOfBytes": "20" | ||
| }, | ||
| "t_array(t_uint256)49_storage": { | ||
| "label": "uint256[49]", | ||
| "numberOfBytes": "1568" | ||
| }, | ||
| "t_array(t_uint256)50_storage": { | ||
| "label": "uint256[50]", | ||
| "numberOfBytes": "1600" | ||
| }, | ||
| "t_bool": { | ||
| "label": "bool", | ||
| "numberOfBytes": "1" | ||
| }, | ||
| "t_contract(ISSVViews)4950": { | ||
| "label": "contract ISSVViews", | ||
| "numberOfBytes": "20" | ||
| }, | ||
| "t_uint256": { | ||
| "label": "uint256", | ||
| "numberOfBytes": "32" | ||
| }, | ||
| "t_uint8": { | ||
| "label": "uint8", | ||
| "numberOfBytes": "1" | ||
| } | ||
| }, | ||
| "namespaces": {} | ||
| } | ||
| } | ||
| } | ||
| } |
10 changes: 10 additions & 0 deletions
10
contracts/upgrades/mainnet/SSVNetworkUpgradeValidatorsPerOperator.sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| // SPDX-License-Identifier: GPL-3.0-or-later | ||
| pragma solidity 0.8.24; | ||
|
|
||
| import "../../SSVNetwork.sol"; | ||
|
|
||
| contract SSVNetworkUpgradeValidatorsPerOperator is SSVNetwork { | ||
| function initializev2(uint32 validatorsPerOperatorLimit_) external reinitializer(_getInitializedVersion() + 1) { | ||
| SSVStorageProtocol.load().validatorsPerOperatorLimit = validatorsPerOperatorLimit_; | ||
| } | ||
| } | ||
10 changes: 10 additions & 0 deletions
10
contracts/upgrades/testnet/holesky/SSVNetworkUpgradeValidatorsPerOperator.sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| // SPDX-License-Identifier: GPL-3.0-or-later | ||
| pragma solidity 0.8.24; | ||
|
|
||
| import "../../../SSVNetwork.sol"; | ||
|
|
||
| contract SSVNetworkUpgradeValidatorsPerOperator is SSVNetwork { | ||
| function initializev2(uint32 validatorsPerOperatorLimit_) external reinitializer(_getInitializedVersion() + 1) { | ||
| SSVStorageProtocol.load().validatorsPerOperatorLimit = validatorsPerOperatorLimit_; | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should do the job.
This means it can be called only once but probably it's still safer to add onlyOwner.