Open
Conversation
GalRogozinski
requested changes
Mar 2, 2025
Contributor
GalRogozinski
left a comment
GalRogozinski
left a comment
There was a problem hiding this comment.
There seems to be some stuff missing here besides tests and the MD file we talked about.
How do you identify consensus instances?
For tests, simply study what is under ssv/duties ssv/postconsensus ssv/preconsensus
ssv/preconfirmation.go
Outdated
| BeaconNetwork: beaconNetwork, | ||
| Share: share, | ||
| QBFTController: qbftController, | ||
| highestDecidedSlot: highestDecidedSlot, |
Contributor
There was a problem hiding this comment.
I believe this field is used for message validation
we need to remember that this will work differently than other duties
Contributor
Author
There was a problem hiding this comment.
By looking up this variable it seems it is not used anywhere...
Maybe I missed something?
ssv/preconfirmation.go
Outdated
Comment on lines
58
to
65
| func (r *PreconfRunner) StartNewDuty(duty types.Duty, quorum uint64) error { | ||
| return r.BaseRunner.baseStartNewDuty(r, duty, quorum) | ||
| } | ||
|
|
||
| // HasRunningDuty returns true if a duty is already running (StartNewDuty called and returned nil) | ||
| func (r *PreconfRunner) HasRunningDuty() bool { | ||
| return r.BaseRunner.hasRunningDuty() | ||
| } |
Contributor
There was a problem hiding this comment.
We said we can have several duties at the same slot?
what change(s) need to be made here?
types/beacon_types.go
Outdated
| DomainSyncCommitteeSelectionProof = [4]byte{0x08, 0x00, 0x00, 0x00} | ||
| DomainContributionAndProof = [4]byte{0x09, 0x00, 0x00, 0x00} | ||
| DomainApplicationBuilder = [4]byte{0x00, 0x00, 0x00, 0x01} | ||
| DomainCommitBoost = [4]byte{0x6d, 0x6d, 0x6f, 0x43} |
…ager implementation, update tests
|
This pull request has been marked as stale due to 60 days of inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a preconfirmation duty to sign and submit preconf requests.