Conversation
GalRogozinski
commented
Mar 13, 2025
GalRogozinski
commented
Mar 13, 2025
| // Upcoming 40M gas limit produces 40M / 16 (call data cost) = 2,500,000 bytes (https://eips.ethereum.org/EIPS/eip-4488) | ||
| // Explanation on why transaction sizes are so big https://github.com/ethereum/consensus-specs/pull/2686 | ||
| // Adding to the rest of the data (see script below), we have: 1,315,964 + 2,500,000 = 3,815,964 bytes ~<= 2^22 | ||
| // Adding to the rest of the data (see script below), we have: 3,291,849 + 2,500,000 = 5,791,849 bytes ~<= 2^23 |
Contributor
Author
There was a problem hiding this comment.
note new figure
GalRogozinski
commented
Mar 16, 2025
|
|
||
| if test.ExpectedRoot != hex.EncodeToString(r[:]) { | ||
| fmt.Printf("expected: %v\n", test.ExpectedRoot) | ||
| fmt.Printf("actuak: %v\n", hex.EncodeToString(r[:])) |
GalRogozinski
commented
Mar 16, 2025
Contributor
Author
GalRogozinski
left a comment
GalRogozinski
left a comment
There was a problem hiding this comment.
Once I change according to review I get:
Field DataSSZ is different than ssz tag size: 8388836 != 8388608
y0sher
approved these changes
Mar 16, 2025
MatusKysel
approved these changes
Mar 17, 2025
alan-ssvlabs
approved these changes
Mar 17, 2025
MatheusFranco99
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take into account blobs and execution requests