ssvlabs · GalRogozinski · Jul 23, 2025 · Jun 24, 2025 · Jun 24, 2025 · Jun 25, 2025
diff --git a/qbft/messages_encoding.go b/qbft/messages_encoding.go
diff --git a/qbft/spectest/all_tests.go b/qbft/spectest/all_tests.go
@@ -132,7 +132,7 @@ var AllTests = []tests.TestF{
 	proposal.NotPreparedPreviouslyJustification,
 	proposal.PreparedPreviouslyJustification,
 	proposal.DifferentJustifications,
-	proposal.JustificationsNotHeighest,
+	proposal.JustificationsNotHighest,
 	proposal.DuplicateMsg,
 	proposal.DuplicateMsgDifferentRoot,
 	proposal.FirstRoundJustification,

diff --git a/.../generate/state_comparison/tests_CreateMsgSpecTest/qbft create message create commit.json b/.../generate/state_comparison/tests_CreateMsgSpecTest/qbft create message create commit.json
@@ -1,5 +1,7 @@
 {
 		"Name": "create commit",
+		"Type": "Message creation: validation of consensus message construction and encoding",
+		"Documentation": "Test creating a commit message for QBFT consensus.",
 		"Value": [
 				1,
 				2,

diff --git a/...generate/state_comparison/tests_CreateMsgSpecTest/qbft create message create prepare.json b/...generate/state_comparison/tests_CreateMsgSpecTest/qbft create message create prepare.json
@@ -1,5 +1,7 @@
 {
 		"Name": "create prepare",
+		"Type": "Message creation: validation of consensus message construction and encoding",
+		"Documentation": "Test creating a prepare message for QBFT consensus.",
 		"Value": [
 				1,
 				2,

diff --git a/.../tests_CreateMsgSpecTest/qbft create message create proposal not previously prepared.json b/.../tests_CreateMsgSpecTest/qbft create message create proposal not previously prepared.json
@@ -1,5 +1,7 @@
 {
 		"Name": "create proposal not previously prepared",
+		"Type": "Message creation: validation of consensus message construction and encoding",
+		"Documentation": "Test creating a proposal message for non-first round when not previously prepared, with round change justifications.",
 		"Value": [
 				1,
 				2,

diff --git a/...ison/tests_CreateMsgSpecTest/qbft create message create proposal previously prepared.json b/...ison/tests_CreateMsgSpecTest/qbft create message create proposal previously prepared.json
@@ -1,5 +1,7 @@
 {
 		"Name": "create proposal previously prepared",
+		"Type": "Message creation: validation of consensus message construction and encoding",
+		"Documentation": "Test creating a proposal message when previously prepared with round change and prepare justifications.",
 		"Value": [
 				1,
 				2,

diff --git a/...enerate/state_comparison/tests_CreateMsgSpecTest/qbft create message create proposal.json b/...enerate/state_comparison/tests_CreateMsgSpecTest/qbft create message create proposal.json
@@ -1,5 +1,7 @@
 {
 		"Name": "create proposal",
+		"Type": "Message creation: validation of consensus message construction and encoding",
+		"Documentation": "Test creating a proposal message when not previously prepared.",
 		"Value": [
 				1,
 				2,

diff --git a/...ts_CreateMsgSpecTest/qbft create message create round change no justification quorum.json b/...ts_CreateMsgSpecTest/qbft create message create round change no justification quorum.json
@@ -1,10 +1,12 @@
 {
 		"Name": "create round change no justification quorum",
+		"Type": "Message creation: validation of consensus message construction and encoding",
+		"Documentation": "Test creating a round change message that was previously prepared but failed to extract a justification quorum, resulting in an unjustified round change.",
 		"Value": [
-				0,
-				0,
-				0,
-				0,
+				1,
+				2,
+				3,
+				4,
 				0,
 				0,
 				0,

diff --git a/.../tests_CreateMsgSpecTest/qbft create message create round change previously prepared.json b/.../tests_CreateMsgSpecTest/qbft create message create round change previously prepared.json
@@ -1,5 +1,7 @@
 {
 		"Name": "create round change previously prepared",
+		"Type": "Message creation: validation of consensus message construction and encoding",
+		"Documentation": "Test creating a round change message when previously prepared with justifications.",
 		"Value": [
 				1,
 				2,

diff --git a/...ate/state_comparison/tests_CreateMsgSpecTest/qbft create message create round change.json b/...ate/state_comparison/tests_CreateMsgSpecTest/qbft create message create round change.json
@@ -1,5 +1,7 @@
 {
 		"Name": "create round change",
+		"Type": "Message creation: validation of consensus message construction and encoding",
+		"Documentation": "Test creating a round change message when not previously prepared.",
 		"Value": [
 				1,
 				2,

diff --git a/...e/state_comparison/tests_MsgSpecTest/qbft message SSZ marshalling of signed messaged.json b/...e/state_comparison/tests_MsgSpecTest/qbft message SSZ marshalling of signed messaged.json
@@ -1,5 +1,7 @@
 {
 		"Name": "SSZ marshalling of signed messaged",
+		"Type": "QBFT message validation: testing message encoding, decoding, and structural integrity",
+		"Documentation": "Test valid SSZ marshaling of a signed QBFT message with justifications.",
 		"Messages": [
 				{
 						"Signatures": [

diff --git a/...st/generate/state_comparison/tests_MsgSpecTest/qbft message commit data nil or len 0.json b/...st/generate/state_comparison/tests_MsgSpecTest/qbft message commit data nil or len 0.json
@@ -1,5 +1,7 @@
 {
 		"Name": "commit data nil or len 0",
+		"Type": "QBFT message validation: testing message encoding, decoding, and structural integrity",
+		"Documentation": "Test encoding of commit data for QBFT message validation.",
 		"Messages": [
 				{
 						"Signatures": [

diff --git a/.../spectest/generate/state_comparison/tests_MsgSpecTest/qbft message duplicate signers.json b/.../spectest/generate/state_comparison/tests_MsgSpecTest/qbft message duplicate signers.json
@@ -1,5 +1,7 @@
 {
 		"Name": "duplicate signers",
+		"Type": "QBFT message validation: testing message encoding, decoding, and structural integrity",
+		"Documentation": "Test signed message with duplicate signers, expecting validation error.",
 		"Messages": [
 				{
 						"Signatures": [

diff --git a/qbft/spectest/generate/state_comparison/tests_MsgSpecTest/qbft message get root.json b/qbft/spectest/generate/state_comparison/tests_MsgSpecTest/qbft message get root.json
@@ -1,5 +1,7 @@
 {
 		"Name": "get root",
+		"Type": "QBFT message validation: testing message encoding, decoding, and structural integrity",
+		"Documentation": "Test GetRoot method on signed QBFT message with justifications.",
 		"Messages": [
 				{
 						"Signatures": [

diff --git a/...test/generate/state_comparison/tests_MsgSpecTest/qbft message invalid hash data root.json b/...test/generate/state_comparison/tests_MsgSpecTest/qbft message invalid hash data root.json
@@ -1,5 +1,7 @@
 {
 		"Name": "invalid hash data root",
+		"Type": "QBFT message validation: testing message encoding, decoding, and structural integrity",
+		"Documentation": "Test an invalid hash data root for QBFT message validation.",
 		"Messages": [
 				{
 						"Signatures": [

diff --git a/...omparison/tests_MsgSpecTest/qbft message invalid prepare justification unmarshalling.json b/...omparison/tests_MsgSpecTest/qbft message invalid prepare justification unmarshalling.json
@@ -1,5 +1,7 @@
 {
 		"Name": "invalid prepare justification unmarshalling",
+		"Type": "QBFT message validation: testing message encoding, decoding, and structural integrity",
+		"Documentation": "Test unmarshalling invalid prepare justifications, expecting validation error during message validation.",
 		"Messages": [
 				{
 						"Signatures": [

diff --git a/...ison/tests_MsgSpecTest/qbft message invalid round change justification unmarshalling.json b/...ison/tests_MsgSpecTest/qbft message invalid round change justification unmarshalling.json
@@ -1,5 +1,7 @@
 {
 		"Name": "invalid round change justification unmarshalling",
+		"Type": "QBFT message validation: testing message encoding, decoding, and structural integrity",
+		"Documentation": "Test unmarshalling invalid round change justifications, expecting validation error during message validation.",
 		"Messages": [
 				{
 						"Signatures": [

diff --git a/...tate_comparison/tests_MsgSpecTest/qbft message marshal RC and Prepare justifications.json b/...tate_comparison/tests_MsgSpecTest/qbft message marshal RC and Prepare justifications.json
@@ -1,5 +1,7 @@
 {
 		"Name": "marshal RC and Prepare justifications",
+		"Type": "QBFT message validation: testing message encoding, decoding, and structural integrity",
+		"Documentation": "Test marshalling round change and prepare justifications for QBFT proposal message.",
 		"Messages": [
 				{
 						"Signatures": [

diff --git a/...tate_comparison/tests_MsgSpecTest/qbft message marshal justifications with full data.json b/...tate_comparison/tests_MsgSpecTest/qbft message marshal justifications with full data.json
@@ -1,5 +1,7 @@
 {
 		"Name": "marshal justifications with full data",
+		"Type": "QBFT message validation: testing message encoding, decoding, and structural integrity",
+		"Documentation": "Test marshalling justifications with full data, which should be omitted during marshalling.",
 		"Messages": [
 				{
 						"Signatures": [

diff --git a/...test/generate/state_comparison/tests_MsgSpecTest/qbft message marshal justifications.json b/...test/generate/state_comparison/tests_MsgSpecTest/qbft message marshal justifications.json
@@ -1,5 +1,7 @@
 {
 		"Name": "marshal justifications",
+		"Type": "QBFT message validation: testing message encoding, decoding, and structural integrity",
+		"Documentation": "Test marshalling justifications without full data for QBFT proposal message.",
 		"Messages": [
 				{
 						"Signatures": [

diff --git a/...est/generate/state_comparison/tests_MsgSpecTest/qbft message msg identifier len == 0.json b/...est/generate/state_comparison/tests_MsgSpecTest/qbft message msg identifier len == 0.json
@@ -1,5 +1,7 @@
 {
 		"Name": "msg identifier len == 0",
+		"Type": "QBFT message validation: testing message encoding, decoding, and structural integrity",
+		"Documentation": "Test message with empty identifier, expecting validation error.",
 		"Messages": [
 				{
 						"Signatures": [

diff --git a/...spectest/generate/state_comparison/tests_MsgSpecTest/qbft message msg identifier nil.json b/...spectest/generate/state_comparison/tests_MsgSpecTest/qbft message msg identifier nil.json
@@ -1,5 +1,7 @@
 {
 		"Name": "msg identifier nil",
+		"Type": "QBFT message validation: testing message encoding, decoding, and structural integrity",
+		"Documentation": "Test message with nil identifier, expecting validation error.",
 		"Messages": [
 				{
 						"Signatures": [

diff --git a/qbft/spectest/generate/state_comparison/tests_MsgSpecTest/qbft message msg type unknown.json b/qbft/spectest/generate/state_comparison/tests_MsgSpecTest/qbft message msg type unknown.json
@@ -1,5 +1,7 @@
 {
 		"Name": "msg type unknown",
+		"Type": "QBFT message validation: testing message encoding, decoding, and structural integrity",
+		"Documentation": "Test message with unknown/invalid message type, expecting validation error.",
 		"Messages": [
 				{
 						"Signatures": [

diff --git a/qbft/spectest/generate/state_comparison/tests_MsgSpecTest/qbft message multi signers.json b/qbft/spectest/generate/state_comparison/tests_MsgSpecTest/qbft message multi signers.json
@@ -1,5 +1,7 @@
 {
 		"Name": "multi signers",
+		"Type": "QBFT message validation: testing message encoding, decoding, and structural integrity",
+		"Documentation": "Test signed message with multiple signers for QBFT message validation.",
 		"Messages": [
 				{
 						"Signatures": [

diff --git a/qbft/spectest/generate/state_comparison/tests_MsgSpecTest/qbft message no signers.json b/qbft/spectest/generate/state_comparison/tests_MsgSpecTest/qbft message no signers.json
@@ -1,5 +1,7 @@
 {
 		"Name": "no signers",
+		"Type": "QBFT message validation: testing message encoding, decoding, and structural integrity",
+		"Documentation": "Test signed message with no signers, expecting validation error.",
 		"Messages": [
 				{
 						"Signatures": [

diff --git a/...ctest/generate/state_comparison/tests_MsgSpecTest/qbft message prepare data encoding.json b/...ctest/generate/state_comparison/tests_MsgSpecTest/qbft message prepare data encoding.json
@@ -1,5 +1,7 @@
 {
 		"Name": "prepare data encoding",
+		"Type": "QBFT message validation: testing message encoding, decoding, and structural integrity",
+		"Documentation": "Test encoding of prepare data for QBFT message validation.",
 		"Messages": [
 				{
 						"Signatures": [

diff --git a/.../state_comparison/tests_MsgSpecTest/qbft message prepare justification unmarshalling.json b/.../state_comparison/tests_MsgSpecTest/qbft message prepare justification unmarshalling.json
@@ -1,5 +1,7 @@
 {
 		"Name": "prepare justification unmarshalling",
+		"Type": "QBFT message validation: testing message encoding, decoding, and structural integrity",
+		"Documentation": "Test unmarshalling prepare justifications from QBFT proposal message.",
 		"Messages": [
 				{
 						"Signatures": [

diff --git a/...ctest/generate/state_comparison/tests_MsgSpecTest/qbft message propose data encoding.json b/...ctest/generate/state_comparison/tests_MsgSpecTest/qbft message propose data encoding.json
@@ -1,5 +1,7 @@
 {
 		"Name": "propose data encoding",
+		"Type": "QBFT message validation: testing message encoding, decoding, and structural integrity",
+		"Documentation": "Test encoding of proposal data with justifications.",
 		"Messages": [
 				{
 						"Signatures": [

diff --git a/.../state_comparison/tests_MsgSpecTest/qbft message rc not prev prepared justifications.json b/.../state_comparison/tests_MsgSpecTest/qbft message rc not prev prepared justifications.json
@@ -1,5 +1,7 @@
 {
 		"Name": "rc not prev prepared justifications",
+		"Type": "QBFT message validation: testing message encoding, decoding, and structural integrity",
+		"Documentation": "Test valid justified round change message without previously prepared justifications.",
 		"Messages": [
 				{
 						"Signatures": [

diff --git a/...rate/state_comparison/tests_MsgSpecTest/qbft message rc prev prepared justifications.json b/...rate/state_comparison/tests_MsgSpecTest/qbft message rc prev prepared justifications.json
@@ -1,5 +1,7 @@
 {
 		"Name": "rc prev prepared justifications",
+		"Type": "QBFT message validation: testing message encoding, decoding, and structural integrity",
+		"Documentation": "Test valid justified round change message with previously prepared justifications.",
 		"Messages": [
 				{
 						"Signatures": [

diff --git a/.../generate/state_comparison/tests_MsgSpecTest/qbft message round change data encoding.json b/.../generate/state_comparison/tests_MsgSpecTest/qbft message round change data encoding.json
@@ -1,5 +1,7 @@
 {
 		"Name": "round change data encoding",
+		"Type": "QBFT message validation: testing message encoding, decoding, and structural integrity",
+		"Documentation": "Test encoding of round change data with justifications.",
 		"Messages": [
 				{
 						"Signatures": [

diff --git a/...e_comparison/tests_MsgSpecTest/qbft message round change justification unmarshalling.json b/...e_comparison/tests_MsgSpecTest/qbft message round change justification unmarshalling.json
@@ -1,5 +1,7 @@
 {
 		"Name": "round change justification unmarshalling",
+		"Type": "QBFT message validation: testing message encoding, decoding, and structural integrity",
+		"Documentation": "Test unmarshalling round change justifications from QBFT proposal message.",
 		"Messages": [
 				{
 						"Signatures": [

diff --git a/...ctest/generate/state_comparison/tests_MsgSpecTest/qbft message round change prepared.json b/...ctest/generate/state_comparison/tests_MsgSpecTest/qbft message round change prepared.json
@@ -1,5 +1,7 @@
 {
 		"Name": "round change prepared",
+		"Type": "QBFT message validation: testing message encoding, decoding, and structural integrity",
+		"Documentation": "Test round change message with prepared value and justifications.",
 		"Messages": [
 				{
 						"Signatures": [

diff --git a/...est/generate/state_comparison/tests_MsgSpecTest/qbft message signed message encoding.json b/...est/generate/state_comparison/tests_MsgSpecTest/qbft message signed message encoding.json
@@ -1,5 +1,7 @@
 {
 		"Name": "signed message encoding",
+		"Type": "QBFT message validation: testing message encoding, decoding, and structural integrity",
+		"Documentation": "Test encoding of signed QBFT message with justifications.",
 		"Messages": [
 				{
 						"Signatures": [

diff --git a/qbft/spectest/generate/state_comparison/tests_MsgSpecTest/qbft message signer 0.json b/qbft/spectest/generate/state_comparison/tests_MsgSpecTest/qbft message signer 0.json
@@ -1,5 +1,7 @@
 {
 		"Name": "signer 0",
+		"Type": "QBFT message validation: testing message encoding, decoding, and structural integrity",
+		"Documentation": "Test signed message with signer ID 0, which is not allowed.",
 		"Messages": [
 				{
 						"Signatures": [

diff --git a/...st/generate/state_comparison/tests_MsgSpecTest/qbft message unmarshal justifications.json b/...st/generate/state_comparison/tests_MsgSpecTest/qbft message unmarshal justifications.json
@@ -1,5 +1,7 @@
 {
 		"Name": "unmarshal justifications",
+		"Type": "QBFT message validation: testing message encoding, decoding, and structural integrity",
+		"Documentation": "Test unmarshalling justifications from QBFT proposal message.",
 		"Messages": [
 				{
 						"Signatures": [

diff --git a/...ectest/generate/state_comparison/tests_MsgSpecTest/qbft message valid hash data root.json b/...ectest/generate/state_comparison/tests_MsgSpecTest/qbft message valid hash data root.json
@@ -1,5 +1,7 @@
 {
 		"Name": "valid hash data root",
+		"Type": "QBFT message validation: testing message encoding, decoding, and structural integrity",
+		"Documentation": "Test a valid hash data root for QBFT message validation.",
 		"Messages": [
 				{
 						"Signatures": [

diff --git a/qbft/spectest/generate/tests/tests.ControllerSpecTest_qbft_controller_broadcast_decided.json b/qbft/spectest/generate/tests/tests.ControllerSpecTest_qbft_controller_broadcast_decided.json
@@ -1,5 +1,7 @@
 {
   "Name": "broadcast decided",
+  "Type": "QBFT controller: validation of consensus state management and instance lifecycle",
+  "Documentation": "Test broadcasting decided message, expecting successful broadcast.",
   "RunInstanceData": [
     {
       "InputValue": "AQIDBA==",
@@ -582,11 +584,9 @@
           },
           "FullData": "AQIDBAUGBwgJAQIDBAUGBwgJAQIDBAUGBwgJ"
         }
-      },
-      "omitempty": null
+      }
     }
   ],
   "OutputMessages": null,
-  "ExpectedError": "",
-  "omitempty": null
+  "ExpectedError": ""
 }
diff --git a/...test/generate/tests/tests.ControllerSpecTest_qbft_controller_decide_current_instance.json b/...test/generate/tests/tests.ControllerSpecTest_qbft_controller_decide_current_instance.json
@@ -1,5 +1,7 @@
 {
   "Name": "decide current instance",
+  "Type": "QBFT controller: validation of consensus state management and instance lifecycle",
+  "Documentation": "Test a decided message received for current running instance, expecting the instance to be decided.",
   "RunInstanceData": [
     {
       "InputValue": "AQIDBA==",
@@ -512,11 +514,9 @@
         "DecidedVal": "AQIDBAUGBwgJAQIDBAUGBwgJAQIDBAUGBwgJ",
         "DecidedCnt": 1,
         "BroadcastedDecided": null
-      },
-      "omitempty": null
+      }
     }
   ],
   "OutputMessages": null,
-  "ExpectedError": "",
-  "omitempty": null
+  "ExpectedError": ""
 }
diff --git a/.../tests/tests.ControllerSpecTest_qbft_controller_decide_current_instance_future_round.json b/.../tests/tests.ControllerSpecTest_qbft_controller_decide_current_instance_future_round.json
@@ -1,5 +1,7 @@
 {
   "Name": "decide current instance future round",
+  "Type": "QBFT controller: validation of consensus state management and instance lifecycle",
+  "Documentation": "Test that a decided msg received for current running instance for a future round should be accepted",
   "RunInstanceData": [
     {
       "InputValue": "AQIDBA==",
@@ -512,11 +514,9 @@
         "DecidedVal": "AQIDBAUGBwgJAQIDBAUGBwgJAQIDBAUGBwgJ",
         "DecidedCnt": 1,
         "BroadcastedDecided": null
-      },
-      "omitempty": null
+      }
     }
   ],
   "OutputMessages": null,
-  "ExpectedError": "",
-  "omitempty": null
+  "ExpectedError": ""
 }
diff --git a/...te/tests/tests.ControllerSpecTest_qbft_controller_decide_current_instance_past_round.json b/...te/tests/tests.ControllerSpecTest_qbft_controller_decide_current_instance_past_round.json
@@ -1,5 +1,7 @@
 {
   "Name": "decide current instance past round",
+  "Type": "QBFT controller: validation of consensus state management and instance lifecycle",
+  "Documentation": "Test a decided message received for current running instance for a past round, expecting the instance to be decided.",
   "RunInstanceData": [
     {
       "InputValue": "AQIDBA==",
@@ -938,11 +940,9 @@
         "DecidedVal": "AQIDBAUGBwgJAQIDBAUGBwgJAQIDBAUGBwgJ",
         "DecidedCnt": 1,
         "BroadcastedDecided": null
-      },
-      "omitempty": null
+      }
     }
   ],
   "OutputMessages": null,
-  "ExpectedError": "",
-  "omitempty": null
+  "ExpectedError": ""
 }