Skip to content

Add private keys to tests#559

Merged
GalRogozinski merged 10 commits intomainfrom
add_test_private_key
Jul 30, 2025
Merged

Add private keys to tests#559
GalRogozinski merged 10 commits intomainfrom
add_test_private_key

Conversation

@alan-ssvlabs
Copy link
Contributor

closes #542

Copy link
Contributor

@GalRogozinski GalRogozinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm
I don't think we need the keys in state comparison... is it possible to remove them

@Tom-ssvlabs Tom-ssvlabs requested review from MatusKysel and removed request for Tom-ssvlabs July 2, 2025 13:51
MatusKysel
MatusKysel previously approved these changes Jul 2, 2025
Copy link
Contributor

@Zacholme7 Zacholme7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small questions, this will help a lot though!

@Zacholme7
Copy link
Contributor

Follow up - Can we just write out the entire TestKeySet to the json file instead?

@alan-ssvlabs
Copy link
Contributor Author

Follow up - Can we just write out the entire TestKeySet to the json file instead?

Updated to include all variables in the test key set. But for the RSA and EdDSA private keys still there are no native exportation functions, so only the key numeric fields are included.

@Zacholme7
Copy link
Contributor

Zacholme7 commented Jul 23, 2025

Thx for including the variables.

As for writing out the keys, can you just write out the PEM? Or it could go from DER into hex

@alan-ssvlabs
Copy link
Contributor Author

As for writing out the keys, can you just write out the PEM? Or it could go from DER into hex

Now the keys are hex encoded PEM :)

@GalRogozinski GalRogozinski merged commit a06a538 into main Jul 30, 2025
2 checks passed
@GalRogozinski GalRogozinski deleted the add_test_private_key branch July 30, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add private keys to tests

5 participants