Add hardcoded test data to json files#566
Merged
GalRogozinski merged 19 commits intomainfrom Aug 5, 2025
Merged
Conversation
jking-aus
previously approved these changes
Jul 31, 2025
ssv/spectest/tests/runner/duties/synccommitteeaggregator/proof_spectest.go
Outdated
Show resolved
Hide resolved
GalRogozinski
approved these changes
Aug 5, 2025
dknopik
approved these changes
Aug 5, 2025
Collaborator
dknopik
left a comment
dknopik
left a comment
There was a problem hiding this comment.
reapproval based on kingy above
y0sher
approved these changes
Aug 5, 2025
Contributor
y0sher
left a comment
y0sher
left a comment
There was a problem hiding this comment.
lgtm, the only thing is that it's making the json file larger which was already an issue before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #557 because constructors are created to generate tests
closes #558