Merged
Conversation
GalRogozinski
approved these changes
Aug 28, 2025
GalRogozinski
approved these changes
Sep 14, 2025
y0sher
approved these changes
Sep 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr addresses a few issues that I had while implementing the QBFT spec tests
All fulldata was mocked to a
[1,2,3,4]byte sequence which we do not allow to be run with qbft. To address this, I movedTestingQBFTFullDatato be valid data. Alongside this, theTestingQbftRootDatawas also fixed. This also applies to theDifferentFullDatawhich I adjusted to be different valid data.Fix the double hash in the create proposal hash for the create message spectests. The root was being passed it which was leading to a double hash so I adjusted it to pass in the fulldata instead
Fix ending roots in create message tests. The expected roots were hardcoded in and after I changed the fulldata and hash of fulldata, I also had to adjust the expected ending root for comparison
I removed some test
invalid_val_check.go: this was testing that a decided message should pass validation even if it has invalid data which should not be possibleinvalid_identifier.go&no_instance_running.go: these felt like implementation detail tests. we are initializing new qbft instances for new identifiers that we encounter as long as it passes validation to account for slow BNscreate_proposal_previously_not_prepared. the round change justifications were for round 2 but the round is being overridden for 10, so the justifications should be for 10. same applies forcreate_proposal_previously_prepared