Skip to content

reduce round #583

Merged
GalRogozinski merged 3 commits intossvlabs:mainfrom
Zacholme7:reduce-round
Oct 27, 2025
Merged

reduce round #583
GalRogozinski merged 3 commits intossvlabs:mainfrom
Zacholme7:reduce-round

Conversation

@Zacholme7
Copy link
Contributor

we have some validation against high rounds and this reduces it into a reasonable range

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR reduces the round number in a QBFT consensus test case from 50 to 10 to address validation constraints against high round numbers. The changes affect the "decide current instance future round" test, which validates how the QBFT controller handles decided messages arriving from future rounds.

The modifications span three files:

  1. The generated JSON test data files where the Round field is updated from 50 to 10
  2. The Go test source file where TestingCommitMultiSignerMessageWithRound is called with round 10 instead of 50
  3. Corresponding signature data and encoded message content that reflects the new round number

This change aligns with the QBFT implementation's round validation mechanisms, specifically the GetCutOffRound() method referenced in CanProcessMessages() which prevents processing of messages when rounds exceed certain thresholds. The test maintains its core functionality of validating future round handling - it still tests the scenario where a decided message arrives for round 10 while the current consensus instance is at round 1. The reduction ensures the test operates within acceptable validation ranges while preserving the test's original purpose of verifying that the controller can properly handle decided messages from future rounds.

Confidence score: 5/5

  • This PR is safe to merge with minimal risk as it only adjusts test data to work within system constraints
  • Score reflects that this is a targeted fix to existing validation logic with no changes to core functionality
  • No files require special attention as the changes are isolated to test data and test generation code

3 files reviewed, no comments

Edit Code Review Bot Settings | Greptile

GalRogozinski
GalRogozinski previously approved these changes Sep 14, 2025
y0sher
y0sher previously approved these changes Sep 14, 2025
@Zacholme7 Zacholme7 dismissed stale reviews from y0sher and GalRogozinski via 2645324 September 16, 2025 15:18
@GalRogozinski GalRogozinski merged commit f9cfb94 into ssvlabs:main Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants