Conversation
y0sher
reviewed
Oct 19, 2025
y0sher
previously approved these changes
Oct 19, 2025
Contributor
y0sher
left a comment
There was a problem hiding this comment.
LGTM, but this also means enforcing adding an error code each time an error is added.
dknopik
approved these changes
Oct 22, 2025
y0sher
approved these changes
Oct 22, 2025
GalRogozinski
approved these changes
Oct 22, 2025
This was referenced Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #514 to implement error-code-based checks in tests (to replace error-message-based ones),
the general approach I took is:
types/error.gofile.jsonfiles), the only other notable change this PR introduces is to split theinvalid partial sig sloterror (invalidatePartialSigMsgForSlotfunc) into 2 distinct errorsinvalid partial sig slotandfuture partial sig msgto be able to differentiate between messages we want to retry vs messages we want to drop (as is implemented in runners: robust message replay ssv#2445)