Aggregator Committee - Drop previous runners and align tests by MatheusFranco99 · Pull Request #592 · ssvlabs/ssv-spec

MatheusFranco99 · 2025-12-17T23:31:34Z

Overview

This PR drops the AggregatorRunner and SyncCommitteeContributorRunner and align the associated tests to the AggregatorCommitteeRunner.

…alidator consensus data tests)

greptile-apps · 2025-12-17T23:31:38Z

Skipped: This PR changes more files than the configured file change limit: (1198 files found, 150 file limit)

ssv/aggregator_committee.go

GalRogozinski

Looks nice

GalRogozinski · 2025-12-23T15:02:26Z

types/consensus_data.go

+// It's only used for the Proposer role.
+// TODO: rename it to associate with Proposer role


Yep, I added this one. But I think this should belong to a dedicated PR, what do you think?

GalRogozinski · 2025-12-23T15:03:32Z

types/beacon_types.go

-	case BNRoleSyncCommitteeContribution:
-		return RoleSyncCommitteeContribution  // Still use old runner for now
+	case BNRoleAggregator, BNRoleSyncCommitteeContribution:
+		return RoleAggregatorCommittee // Still use old runner for now


the comment is correct?

Nope. Removed it

GalRogozinski · 2025-12-23T15:07:00Z

types/beacon_types.go

@@ -48,12 +48,11 @@ const (

 	BNRoleValidatorRegistration
 	BNRoleVoluntaryExit
-	BNRoleAggregatorCommittee // Internal SSV role combining Aggregator + SyncCommitteeContribution


I don't get what I am seeing on Github
This is deleted but later used?

BNRoleAggregatorCommittee was added in the original PR but I removed it here because it's not a beacon role, only a runner role 😅

GalRogozinski · 2025-12-23T15:10:33Z

ssv/value_check.go

@@ -180,7 +180,7 @@ func AggregatorCommitteeValueCheckF(
 	return func(data []byte) error {
 		cd := &types.AggregatorCommitteeConsensusData{}
 		if err := cd.Decode(data); err != nil {
-			return errors.Wrap(err, "failed decoding aggregator committee consensus data")
+			return types.WrapError(types.AggCommConsensusDataDecodeErrorCode, errors.Wrap(err, "failed decoding aggregator committee consensus data"))


in this file we still need 2 value check for attestation aggregator and SC contribution?

I thought i have removed it here, but I actually only did in a later PR. Still, removing it here as well. Thanks!

GalRogozinski · 2025-12-23T15:12:56Z

types/spectest/tests/validatorconsensusdata/invalid_aggregator_validation.go

@@ -1,39 +0,0 @@
-package validatorconsensusdata


no need for new tests?

Several tests are added but in a new package

GalRogozinski · 2025-12-23T15:13:06Z

types/spectest/tests/validatorconsensusdata/invalid_sync_committee_cntribution_validation.go

@@ -1,23 +0,0 @@
-package validatorconsensusdata


no need for new tests?

types/spectest/tests/validatorconsensusdata/sync_committee_contrib_no_justifications.go

* draft * fix aggregator committee - sync committee contribution only test * bug fix * bug fix * add 20-validator test for sync committee aggregator * add test for aggregator and sync committee contribution duties * lint * merge with main * missing tests * support fulu in GetAggregateAndProofs * fix fulu aggregate and proof * fix missing fulu cases * fix leftovers * fix passing slot in contributionProofMsg * Revert "fix passing slot in contributionProofMsg" This reverts commit 226659d. * Aggregator Committee - Drop previous runners and align tests (#592) * remove aggregatorCommittee from BeaconRole * remove aggregator and scc roles * remove agg and scc from ValidatorConsensusData * generate ssz encoding * align testingutils to remove reference to agg and scc alone * add agg committee consensus data tests (and remove agg and scc from validator consensus data tests) * generate types JSON tests * drop agg and scc runners; fix agg committee runner issue * align testingutils for agg committee tests * value check tests * preconsensus tests * post consensus tests * duties tests * runner construction tests * consensus tests * happy flow test * dutyexe tests * add test docs; fix msg processing test * add all tests * generate JSON tests * apply suggestions * Aggregator Committee Mixed Duties Tests (#593) * remove aggregatorCommittee from BeaconRole * remove aggregator and scc roles * remove agg and scc from ValidatorConsensusData * generate ssz encoding * align testingutils to remove reference to agg and scc alone * add agg committee consensus data tests (and remove agg and scc from validator consensus data tests) * generate types JSON tests * drop agg and scc runners; fix agg committee runner issue * align testingutils for agg committee tests * value check tests * preconsensus tests * post consensus tests * duties tests * runner construction tests * consensus tests * happy flow test * dutyexe tests * add test docs; fix msg processing test * add all tests * generate JSON tests * drop weird json tests in unintended directory * add mixed agg+scc pre-consensus tests * generate JSON tests * add error code * increase number of Contributors * add post-consensus mixed agg committee tests * generate JSON tests * fixed remaining mixed tests * generate JSON tests * fix lint (remove unused functions) * avoid in-place sorting * update ssz hash tags * apply suggestions * solve TODOs * revert deleted Alan runner roles * revert deleted ValidatorConsensusData methods * generate tests * Revert "generate tests" This reverts commit 441a53a. * Revert "revert deleted ValidatorConsensusData methods" This reverts commit cb04d43. * Revert "revert deleted Alan runner roles" This reverts commit 69a6a65. * Agg comm improvements (#594) * remove aggregatorCommittee from BeaconRole * remove aggregator and scc roles * remove agg and scc from ValidatorConsensusData * generate ssz encoding * align testingutils to remove reference to agg and scc alone * add agg committee consensus data tests (and remove agg and scc from validator consensus data tests) * generate types JSON tests * drop agg and scc runners; fix agg committee runner issue * align testingutils for agg committee tests * value check tests * preconsensus tests * post consensus tests * duties tests * runner construction tests * consensus tests * happy flow test * dutyexe tests * add test docs; fix msg processing test * add all tests * generate JSON tests * drop weird json tests in unintended directory * add mixed agg+scc pre-consensus tests * generate JSON tests * add error code * increase number of Contributors * add post-consensus mixed agg committee tests * generate JSON tests * add agg committee duty validation; add psgi msg sorting; * add sorting and duty validation tests * generate JSON tests * fixed remaining mixed tests * generate JSON tests * fix lint (remove unused functions) * change AggregatorCommitteeConsensusData to reduce duplicated data overhead * align tests * generate JSON tests * fix maximum ssz sizes * avoid in-place sorting * add test docs * remove unused test docs * fix maximum-size tests * generate JSON tests * fix test: duty with diff slots * add max size test for aggCommCD * add size tests for phase0 and electra attestations; fix ssz max size for attestation in AggCommCD * fix lint issues * fix test dir (no multiple duty) * fix versions data * maximum duty possible test * fix lint * apply suggestions (remove sorting feature; remove unused errors; use subnet for contribution) * clarify validator sync committee index usage * change subnetID computation to avoid errors * generate JSON tests * tests for: invalid quorum; invalid quorum then valid quorum; * generate JSON tests * generate JSON tests with new error numbers * remove deprecated partial signature types * generate JSON tests * generate SSZ files * value check att decoding check * generate JSON tests * apply suggestions * Rename ValidatorConsensusData to ProposerConsensusData (#596) * remove aggregatorCommittee from BeaconRole * remove aggregator and scc roles * remove agg and scc from ValidatorConsensusData * generate ssz encoding * align testingutils to remove reference to agg and scc alone * add agg committee consensus data tests (and remove agg and scc from validator consensus data tests) * generate types JSON tests * drop agg and scc runners; fix agg committee runner issue * align testingutils for agg committee tests * value check tests * preconsensus tests * post consensus tests * duties tests * runner construction tests * consensus tests * happy flow test * dutyexe tests * add test docs; fix msg processing test * add all tests * generate JSON tests * drop weird json tests in unintended directory * add mixed agg+scc pre-consensus tests * generate JSON tests * add error code * increase number of Contributors * add post-consensus mixed agg committee tests * generate JSON tests * add agg committee duty validation; add psgi msg sorting; * add sorting and duty validation tests * generate JSON tests * fixed remaining mixed tests * generate JSON tests * fix lint (remove unused functions) * change AggregatorCommitteeConsensusData to reduce duplicated data overhead * align tests * generate JSON tests * fix maximum ssz sizes * avoid in-place sorting * add test docs * remove unused test docs * fix maximum-size tests * generate JSON tests * fix test: duty with diff slots * add max size test for aggCommCD * add size tests for phase0 and electra attestations; fix ssz max size for attestation in AggCommCD * fix lint issues * fix test dir (no multiple duty) * fix versions data * maximum duty possible test * fix lint * apply suggestions (remove sorting feature; remove unused errors; use subnet for contribution) * clarify validator sync committee index usage * change subnetID computation to avoid errors * generate JSON tests * tests for: invalid quorum; invalid quorum then valid quorum; * generate JSON tests * generate JSON tests with new error numbers * rename ValidatorConsensusData -> ProposerConsensusData * align tests * generate JSON tests * fix renaming on merge * make runner role explicit * generate JSON tests * Aggregator Committee - Fix committee runners management (#597) * remove aggregatorCommittee from BeaconRole * remove aggregator and scc roles * remove agg and scc from ValidatorConsensusData * generate ssz encoding * align testingutils to remove reference to agg and scc alone * add agg committee consensus data tests (and remove agg and scc from validator consensus data tests) * generate types JSON tests * drop agg and scc runners; fix agg committee runner issue * align testingutils for agg committee tests * value check tests * preconsensus tests * post consensus tests * duties tests * runner construction tests * consensus tests * happy flow test * dutyexe tests * add test docs; fix msg processing test * add all tests * generate JSON tests * drop weird json tests in unintended directory * add mixed agg+scc pre-consensus tests * generate JSON tests * add error code * increase number of Contributors * add post-consensus mixed agg committee tests * generate JSON tests * add agg committee duty validation; add psgi msg sorting; * add sorting and duty validation tests * generate JSON tests * fixed remaining mixed tests * generate JSON tests * fix lint (remove unused functions) * change AggregatorCommitteeConsensusData to reduce duplicated data overhead * align tests * generate JSON tests * fix maximum ssz sizes * avoid in-place sorting * add test docs * remove unused test docs * fix maximum-size tests * generate JSON tests * fix test: duty with diff slots * add max size test for aggCommCD * add size tests for phase0 and electra attestations; fix ssz max size for attestation in AggCommCD * fix lint issues * fix test dir (no multiple duty) * fix versions data * maximum duty possible test * fix lint * apply suggestions (remove sorting feature; remove unused errors; use subnet for contribution) * clarify validator sync committee index usage * change subnetID computation to avoid errors * generate JSON tests * tests for: invalid quorum; invalid quorum then valid quorum; * generate JSON tests * generate JSON tests with new error numbers * remove deprecated partial signature types * generate JSON tests * generate SSZ files * fix committee to have agg and comm runners * align testing utils. Fix Committee constructor to a common one, and align tests execution * add test for comm + agg comm duties in the same slot * generate JSON tests * remove unused function * add tests for error cases in committee * add test for mixed duties for multiple slots * remove unused parameter * set fork-persistent values for psig types * generate JSON tests * set max ssz sizes exportable --------- Co-authored-by: Alan <alan@ssvlabs.io> Co-authored-by: Nikita Kryuchkov <nkryuchkov10@gmail.com> Co-authored-by: MatheusFranco99 <48058141+MatheusFranco99@users.noreply.github.com>

MatheusFranco99 added 20 commits December 17, 2025 15:57

remove aggregatorCommittee from BeaconRole

877ad54

remove aggregator and scc roles

6042b46

remove agg and scc from ValidatorConsensusData

43c258c

generate ssz encoding

77cafc6

align testingutils to remove reference to agg and scc alone

c29cab4

add agg committee consensus data tests (and remove agg and scc from v…

d0fe1b7

…alidator consensus data tests)

generate types JSON tests

80d2575

drop agg and scc runners; fix agg committee runner issue

15c0097

align testingutils for agg committee tests

3a90436

value check tests

eb2603b

preconsensus tests

2f36539

post consensus tests

35494fe

duties tests

29f8546

runner construction tests

0d94a9f

consensus tests

5522634

happy flow test

1eea4d8

dutyexe tests

c95d636

add test docs; fix msg processing test

e746f6f

add all tests

e93301b

generate JSON tests

0ca88b3

MatheusFranco99 self-assigned this Dec 17, 2025

MatheusFranco99 requested a review from GalRogozinski December 17, 2025 23:31

GalRogozinski reviewed Dec 22, 2025

View reviewed changes

ssv/aggregator_committee.go Show resolved Hide resolved

MatheusFranco99 added the fork label Dec 23, 2025

MatheusFranco99 mentioned this pull request Dec 23, 2025

Aggregator Committee Tests #573

Closed

MatheusFranco99 requested review from GalRogozinski and y0sher December 23, 2025 12:52

GalRogozinski reviewed Dec 23, 2025

View reviewed changes

apply suggestions

a65e701

GalRogozinski approved these changes Dec 24, 2025

View reviewed changes

GalRogozinski merged commit f573cf0 into aggregator-committee Dec 24, 2025
2 checks passed

GalRogozinski deleted the agg-comm-drop-previous-duty-types branch December 24, 2025 09:09

		// It's only used for the Proposer role.
		// TODO: rename it to associate with Proposer role

Conversation

MatheusFranco99 commented Dec 17, 2025

Overview

Uh oh!

greptile-apps bot commented Dec 17, 2025

Uh oh!

Uh oh!

GalRogozinski left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants