Agg comm improvements by MatheusFranco99 · Pull Request #594 · ssvlabs/ssv-spec

MatheusFranco99 · 2025-12-21T04:04:08Z

Overview

This PR adds improvements to the Aggregator Commmittee Runner:

duty validation
partial signature message sorting
improve consensus data to remove duplicated redundant data (for the same subnets)
add explicit logic about pre-consensus finalization (namely, whenever at least a quorum for one validator is reached, proceed to consensus)

…alidator consensus data tests)

types/consensus_data.go

GalRogozinski

Please go over unresolved comments
thanks!

ssv/aggregator_committee.go

types/error.go

ssv/aggregator_committee.go

GalRogozinski

Add a test that checks that a preconsensus quorum was completed but not aggregator was found, but then later comes another message that completes the missing validator that may be an aggregator

…subnet for contribution)

MatheusFranco99 · 2025-12-26T16:24:34Z

@GalRogozinski added the tests. Let me know if you agree with it

y0sher · 2025-12-28T18:25:48Z

ssv/value_check.go

@@ -133,14 +133,6 @@ func AggregatorCommitteeValueCheckF(
 			return errors.Wrap(err, "invalid value")
 		}

-		// Basic validation - consensus data should have either aggregator or sync committee data


did this move to somewhere or we don't need this check?

This was done when ValidatorConsensusData had aggregator or scc type and we wanted to validate that the encoded obj was of the correct type. Here, AggregatorCommitteeConsensusData already has some decoded data. At most, we could decode every attestation, which is currently []byte to confirm they are correct. Wdyt @GalRogozinski ?

Solved in the main PR in this commit

GalRogozinski

LGTM
just quickly answer unresolved comments

GalRogozinski

@MatheusFranco99
After you answer the comments, feel free to merge to the base branch if you think it will help you with conflict management

* draft * fix aggregator committee - sync committee contribution only test * bug fix * bug fix * add 20-validator test for sync committee aggregator * add test for aggregator and sync committee contribution duties * lint * merge with main * missing tests * support fulu in GetAggregateAndProofs * fix fulu aggregate and proof * fix missing fulu cases * fix leftovers * fix passing slot in contributionProofMsg * Revert "fix passing slot in contributionProofMsg" This reverts commit 226659d. * Aggregator Committee - Drop previous runners and align tests (#592) * remove aggregatorCommittee from BeaconRole * remove aggregator and scc roles * remove agg and scc from ValidatorConsensusData * generate ssz encoding * align testingutils to remove reference to agg and scc alone * add agg committee consensus data tests (and remove agg and scc from validator consensus data tests) * generate types JSON tests * drop agg and scc runners; fix agg committee runner issue * align testingutils for agg committee tests * value check tests * preconsensus tests * post consensus tests * duties tests * runner construction tests * consensus tests * happy flow test * dutyexe tests * add test docs; fix msg processing test * add all tests * generate JSON tests * apply suggestions * Aggregator Committee Mixed Duties Tests (#593) * remove aggregatorCommittee from BeaconRole * remove aggregator and scc roles * remove agg and scc from ValidatorConsensusData * generate ssz encoding * align testingutils to remove reference to agg and scc alone * add agg committee consensus data tests (and remove agg and scc from validator consensus data tests) * generate types JSON tests * drop agg and scc runners; fix agg committee runner issue * align testingutils for agg committee tests * value check tests * preconsensus tests * post consensus tests * duties tests * runner construction tests * consensus tests * happy flow test * dutyexe tests * add test docs; fix msg processing test * add all tests * generate JSON tests * drop weird json tests in unintended directory * add mixed agg+scc pre-consensus tests * generate JSON tests * add error code * increase number of Contributors * add post-consensus mixed agg committee tests * generate JSON tests * fixed remaining mixed tests * generate JSON tests * fix lint (remove unused functions) * avoid in-place sorting * update ssz hash tags * apply suggestions * solve TODOs * revert deleted Alan runner roles * revert deleted ValidatorConsensusData methods * generate tests * Revert "generate tests" This reverts commit 441a53a. * Revert "revert deleted ValidatorConsensusData methods" This reverts commit cb04d43. * Revert "revert deleted Alan runner roles" This reverts commit 69a6a65. * Agg comm improvements (#594) * remove aggregatorCommittee from BeaconRole * remove aggregator and scc roles * remove agg and scc from ValidatorConsensusData * generate ssz encoding * align testingutils to remove reference to agg and scc alone * add agg committee consensus data tests (and remove agg and scc from validator consensus data tests) * generate types JSON tests * drop agg and scc runners; fix agg committee runner issue * align testingutils for agg committee tests * value check tests * preconsensus tests * post consensus tests * duties tests * runner construction tests * consensus tests * happy flow test * dutyexe tests * add test docs; fix msg processing test * add all tests * generate JSON tests * drop weird json tests in unintended directory * add mixed agg+scc pre-consensus tests * generate JSON tests * add error code * increase number of Contributors * add post-consensus mixed agg committee tests * generate JSON tests * add agg committee duty validation; add psgi msg sorting; * add sorting and duty validation tests * generate JSON tests * fixed remaining mixed tests * generate JSON tests * fix lint (remove unused functions) * change AggregatorCommitteeConsensusData to reduce duplicated data overhead * align tests * generate JSON tests * fix maximum ssz sizes * avoid in-place sorting * add test docs * remove unused test docs * fix maximum-size tests * generate JSON tests * fix test: duty with diff slots * add max size test for aggCommCD * add size tests for phase0 and electra attestations; fix ssz max size for attestation in AggCommCD * fix lint issues * fix test dir (no multiple duty) * fix versions data * maximum duty possible test * fix lint * apply suggestions (remove sorting feature; remove unused errors; use subnet for contribution) * clarify validator sync committee index usage * change subnetID computation to avoid errors * generate JSON tests * tests for: invalid quorum; invalid quorum then valid quorum; * generate JSON tests * generate JSON tests with new error numbers * remove deprecated partial signature types * generate JSON tests * generate SSZ files * value check att decoding check * generate JSON tests * apply suggestions * Rename ValidatorConsensusData to ProposerConsensusData (#596) * remove aggregatorCommittee from BeaconRole * remove aggregator and scc roles * remove agg and scc from ValidatorConsensusData * generate ssz encoding * align testingutils to remove reference to agg and scc alone * add agg committee consensus data tests (and remove agg and scc from validator consensus data tests) * generate types JSON tests * drop agg and scc runners; fix agg committee runner issue * align testingutils for agg committee tests * value check tests * preconsensus tests * post consensus tests * duties tests * runner construction tests * consensus tests * happy flow test * dutyexe tests * add test docs; fix msg processing test * add all tests * generate JSON tests * drop weird json tests in unintended directory * add mixed agg+scc pre-consensus tests * generate JSON tests * add error code * increase number of Contributors * add post-consensus mixed agg committee tests * generate JSON tests * add agg committee duty validation; add psgi msg sorting; * add sorting and duty validation tests * generate JSON tests * fixed remaining mixed tests * generate JSON tests * fix lint (remove unused functions) * change AggregatorCommitteeConsensusData to reduce duplicated data overhead * align tests * generate JSON tests * fix maximum ssz sizes * avoid in-place sorting * add test docs * remove unused test docs * fix maximum-size tests * generate JSON tests * fix test: duty with diff slots * add max size test for aggCommCD * add size tests for phase0 and electra attestations; fix ssz max size for attestation in AggCommCD * fix lint issues * fix test dir (no multiple duty) * fix versions data * maximum duty possible test * fix lint * apply suggestions (remove sorting feature; remove unused errors; use subnet for contribution) * clarify validator sync committee index usage * change subnetID computation to avoid errors * generate JSON tests * tests for: invalid quorum; invalid quorum then valid quorum; * generate JSON tests * generate JSON tests with new error numbers * rename ValidatorConsensusData -> ProposerConsensusData * align tests * generate JSON tests * fix renaming on merge * make runner role explicit * generate JSON tests * Aggregator Committee - Fix committee runners management (#597) * remove aggregatorCommittee from BeaconRole * remove aggregator and scc roles * remove agg and scc from ValidatorConsensusData * generate ssz encoding * align testingutils to remove reference to agg and scc alone * add agg committee consensus data tests (and remove agg and scc from validator consensus data tests) * generate types JSON tests * drop agg and scc runners; fix agg committee runner issue * align testingutils for agg committee tests * value check tests * preconsensus tests * post consensus tests * duties tests * runner construction tests * consensus tests * happy flow test * dutyexe tests * add test docs; fix msg processing test * add all tests * generate JSON tests * drop weird json tests in unintended directory * add mixed agg+scc pre-consensus tests * generate JSON tests * add error code * increase number of Contributors * add post-consensus mixed agg committee tests * generate JSON tests * add agg committee duty validation; add psgi msg sorting; * add sorting and duty validation tests * generate JSON tests * fixed remaining mixed tests * generate JSON tests * fix lint (remove unused functions) * change AggregatorCommitteeConsensusData to reduce duplicated data overhead * align tests * generate JSON tests * fix maximum ssz sizes * avoid in-place sorting * add test docs * remove unused test docs * fix maximum-size tests * generate JSON tests * fix test: duty with diff slots * add max size test for aggCommCD * add size tests for phase0 and electra attestations; fix ssz max size for attestation in AggCommCD * fix lint issues * fix test dir (no multiple duty) * fix versions data * maximum duty possible test * fix lint * apply suggestions (remove sorting feature; remove unused errors; use subnet for contribution) * clarify validator sync committee index usage * change subnetID computation to avoid errors * generate JSON tests * tests for: invalid quorum; invalid quorum then valid quorum; * generate JSON tests * generate JSON tests with new error numbers * remove deprecated partial signature types * generate JSON tests * generate SSZ files * fix committee to have agg and comm runners * align testing utils. Fix Committee constructor to a common one, and align tests execution * add test for comm + agg comm duties in the same slot * generate JSON tests * remove unused function * add tests for error cases in committee * add test for mixed duties for multiple slots * remove unused parameter * set fork-persistent values for psig types * generate JSON tests * set max ssz sizes exportable --------- Co-authored-by: Alan <alan@ssvlabs.io> Co-authored-by: Nikita Kryuchkov <nkryuchkov10@gmail.com> Co-authored-by: MatheusFranco99 <48058141+MatheusFranco99@users.noreply.github.com>

MatheusFranco99 added 30 commits December 17, 2025 15:57

remove aggregatorCommittee from BeaconRole

877ad54

remove aggregator and scc roles

6042b46

remove agg and scc from ValidatorConsensusData

43c258c

generate ssz encoding

77cafc6

align testingutils to remove reference to agg and scc alone

c29cab4

add agg committee consensus data tests (and remove agg and scc from v…

d0fe1b7

…alidator consensus data tests)

generate types JSON tests

80d2575

drop agg and scc runners; fix agg committee runner issue

15c0097

align testingutils for agg committee tests

3a90436

value check tests

eb2603b

preconsensus tests

2f36539

post consensus tests

35494fe

duties tests

29f8546

runner construction tests

0d94a9f

consensus tests

5522634

happy flow test

1eea4d8

dutyexe tests

c95d636

add test docs; fix msg processing test

e746f6f

add all tests

e93301b

generate JSON tests

0ca88b3

drop weird json tests in unintended directory

cafd39f

add mixed agg+scc pre-consensus tests

2e3c59e

generate JSON tests

0b017e7

add error code

de5bb1d

increase number of Contributors

36b5db0

add post-consensus mixed agg committee tests

a1dcc04

generate JSON tests

c8ced68

add agg committee duty validation; add psgi msg sorting;

983436a

add sorting and duty validation tests

725412b

generate JSON tests

e67f91f

MatheusFranco99 added 3 commits December 24, 2025 12:08

fix versions data

0eb1e47

maximum duty possible test

cd761b8

fix lint

28ab5c9

GalRogozinski reviewed Dec 24, 2025

View reviewed changes

types/consensus_data.go Show resolved Hide resolved

GalRogozinski requested changes Dec 24, 2025

View reviewed changes

GalRogozinski reviewed Dec 25, 2025

View reviewed changes

ssv/aggregator_committee.go Show resolved Hide resolved

GalRogozinski reviewed Dec 25, 2025

View reviewed changes

types/error.go Outdated Show resolved Hide resolved

GalRogozinski reviewed Dec 25, 2025

View reviewed changes

types/error.go Outdated Show resolved Hide resolved

GalRogozinski reviewed Dec 25, 2025

View reviewed changes

ssv/aggregator_committee.go Show resolved Hide resolved

GalRogozinski requested changes Dec 25, 2025

View reviewed changes

MatheusFranco99 added 6 commits December 26, 2025 10:24

apply suggestions (remove sorting feature; remove unused errors; use …

b1dde26

…subnet for contribution)

clarify validator sync committee index usage

c6e5fd8

change subnetID computation to avoid errors

6d4decb

generate JSON tests

4f30d5b

tests for: invalid quorum; invalid quorum then valid quorum;

d184645

generate JSON tests

63c6233

MatheusFranco99 added 3 commits December 26, 2025 17:08

Merge branch 'aggregator-committee' into agg-comm-improvements

172ef5b

generate JSON tests with new error numbers

1bb7ec3

Merge branch 'aggregator-committee' into agg-comm-improvements

e2815a7

y0sher reviewed Dec 28, 2025

View reviewed changes

y0sher approved these changes Dec 29, 2025

View reviewed changes

GalRogozinski reviewed Jan 1, 2026

View reviewed changes

MatheusFranco99 added 3 commits January 2, 2026 11:49

remove deprecated partial signature types

6839788

generate JSON tests

25d060a

generate SSZ files

18e3f37

MatheusFranco99 merged commit 074bb23 into aggregator-committee Jan 2, 2026

MatheusFranco99 deleted the agg-comm-improvements branch January 2, 2026 16:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Agg comm improvements#594

Agg comm improvements#594
MatheusFranco99 merged 66 commits intoaggregator-committeefrom
agg-comm-improvements

MatheusFranco99 commented Dec 21, 2025 •

edited

Loading

Uh oh!

Uh oh!

GalRogozinski left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GalRogozinski left a comment

Uh oh!

MatheusFranco99 commented Dec 26, 2025

Uh oh!

y0sher Dec 28, 2025

Uh oh!

MatheusFranco99 Jan 2, 2026

Uh oh!

MatheusFranco99 Jan 2, 2026

Uh oh!

GalRogozinski left a comment

Uh oh!

GalRogozinski left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

MatheusFranco99 commented Dec 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Uh oh!

Uh oh!

GalRogozinski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GalRogozinski left a comment

Choose a reason for hiding this comment

Uh oh!

MatheusFranco99 commented Dec 26, 2025

Uh oh!

y0sher Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

MatheusFranco99 Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

MatheusFranco99 Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

GalRogozinski left a comment

Choose a reason for hiding this comment

Uh oh!

GalRogozinski left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MatheusFranco99 commented Dec 21, 2025 •

edited

Loading