Skip to content

Fix multiple equal selection signatures in Aggregator Committee #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GalRogozinski merged 3 commits into from
Feb 12, 2026
Merged

Fix multiple equal selection signatures in Aggregator Committee #603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
638a53d
sign once per validator subnet
MatheusFranco99 Feb 10, 2026
7b1ed4d
add test for duplicated subnets
MatheusFranco99 Feb 10, 2026
fb6f097
generate JSON tests
MatheusFranco99 Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
6 changes: 6 additions & 0 deletions ssv/aggregator_committee.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,9 +535,15 @@ func (r *AggregatorCommitteeRunner) executeDuty(duty types.Duty) error {

case types.BNRoleSyncCommitteeContribution:
// Sign sync committee selection proofs for each subcommittee
seenSubnets := make(map[uint64]struct{})
for _, index := range vDuty.ValidatorSyncCommitteeIndices {
subnet := r.GetBeaconNode().SyncCommitteeSubnetID(phase0.CommitteeIndex(index))

if _, seen := seenSubnets[subnet]; seen {
continue
}
seenSubnets[subnet] = struct{}{}

data := &altair.SyncAggregatorSelectionData{
Slot: duty.DutySlot(),
SubcommitteeIndex: subnet,
Expand Down
1 change: 1 addition & 0 deletions ssv/spectest/all_tests.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ var AllTests = []tests.TestF{
preconsensus.InvalidExpectedRoot,
preconsensus.DuplicateMsg,
preconsensus.DuplicateMsgDifferentRoots,
preconsensus.DuplicateMsgSameSubnet,
preconsensus.PostFinish,
preconsensus.PostDecided,
preconsensus.PostQuorum,
Expand Down
4 changes: 2 additions & 2 deletions ...ator_committee_runner_duty_with_different_slots/aggregator committee mixed (electra).json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@
"ValidatorCommitteeIndex": 11,
"ValidatorSyncCommitteeIndices": [
0,
1,
2
129,
257
]
}
]
Expand Down
4 changes: 2 additions & 2 deletions ...gator_committee_runner_duty_with_different_slots/aggregator committee mixed (phase0).json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@
"ValidatorCommitteeIndex": 11,
"ValidatorSyncCommitteeIndices": [
0,
1,
2
129,
257
]
}
]
Expand Down
18 changes: 14 additions & 4 deletions ...r_committee_runner_happy_flow/1 aggregator and sync committee contribution (electra).json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,16 @@
"1": "r6cNtmo/vVlAhAgKMq7dQ5qNfehUJjJ1qaYvxL0Kyzw0+XjZVbJec3ipO1x2o0jsEVKqr4hyUh28/122UXO6SSEL4fVwQh3H1gU17e2FfYInMDESrJAryMxTLhE7hqTu",
"2": "r27iZ+bBgrZqVwJJCUNguGFrDivc5TUmR3hil4Un3e6Sy4zGoVkIFtITQnObCFw6Apyfu4YtdgkKif9j98EF5nq78cYH7hpl3OOCYNMKdnizJNek0zSk36whUI/9Ubr3",
"3": "pQ+He0bj+BUtS7x1PvC4kSE+5qzFKre8ed+MevwrXZZYHg+Q0v7Bhm1gUGnJakLUFUmFLZvm323Q8O5ULL0D49HcXfxe10d41H8JjgPxlZFqDkc87EthCF5FzJvI3k/4"
},
"e82ed32828596935cb06cd61a0b7d1512f230ec827b2696e02cc8a06766d36e8": {
"1": "mClFs3PUP5PEfmpt6ZJYsZb1/aO706kJiDxHWAx7ln8hkU10G+Hpfj9V+ojhkvHYFheB1uXcn6RjBMLVDQDttuRvjC6HqN8QuHI/Xo/BrvPqvAV4O4unH2CgcZ0+5xQH",
"2": "lDxfoZr0mUhOZeTQ5QDtvTzS3jFMFOiYK8EVDGDmRn5RcrLFvO4NR2AwFD+Aak5+Alc1ZophBPjCJen0LluubDJbjV/8hF7mRe4Jg/Uue8zWEP95KrgvIiBh4kd8YwdD",
"3": "hJLzLw1O9FMeMfTBuH9pWVv1LB22PUdhM2lw+bBUweEw0gro5lHHY1ZyLTcVXj8HEY4F63clZeboJRkUoeXbyrhCLrkL6CwQzmsueudybvDe6wbM1q0drQTGQim9p0c7"
},
"fc774901fd0cd1a1a6ae90accf26e4985d6e4718555afa2d44e5a72da0200215": {
"1": "ggqKcVUMmveCm7cCyFcIAR6ESEuigGc4/FIGbZue+ay9/J7DyuQ+5EOxYOHPwvB/DCCWSLYv2LEZEGfzRKOJXMuVgaf/7NfZnR2JAxM50AKmUvoz1X6Ss3oPrSlekMqI",
"2": "r1JkMVbtbb1YLfcry2KabKDzl9H+ZV0xv9aGY65RBzs5jNJeHUEoNYR3EvvOW/jAEyc5fAh6ng+7bL8K25Bqa8NRIFuqYUxUP+LLC8ZUnmFzFbblMZhlBPwGP2p3N2jp",
"3": "s8PZsWo9Lf5H9mnWxxc03/FW2wtJKJhsZiwhIiw/vUhOljBMhgIgsTsEifqVzpv/FLg3Xk6X2+FS6Di3tHrys8bkvYApbMgec/FUyQY4QMfaIRs5bmY2LY5EFrn3wxNA"
}
}
},
Expand Down Expand Up @@ -312,7 +322,7 @@
"Msgs": {}
}
},
"StartValue": "BgAAAAAAAAAcAAAAjAAAAJQAAACVAQAA5QIAAAEAAAAAAAAAsHYm/q4noQwTr1qWt4VHO9r+bkKLz2/M4N8A93372b2pnep8ml6fxeWZt62b22ITElOVZ9CQPruL3OzKbx8CKT5oaMlQqUcQ8LwzhtsD7gQWgR343xC+HmpUW34u+oVhAwAAAAAAAAADAAAAAAAAAAQAAADsAAAADEhxAAAAAAAAAAAAAAAAAAECAwQFBgcICQoBAgMEBQYHCAkKAQIDBAUGBwgJCgECAAAAAAAAAAABAgMEBQYHCAkKAQIDBAUGBwgJCgECAwQFBgcICQoBAgEAAAAAAAAAAQIDBAUGBwgJCgECAwQFBgcICQoBAgMEBQYHCAkKAQIAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABAQAAAAAAAACEtEDbTIEO0amAp/qhvmplg4lSQuqyrH8e3zK/XoNgn6pvQOpnSt0KWIj5+h4oWUQXu1Jzmy175EeeuH8vGZcv3wn4eAFNy1/tqkUVvEGhq5W6CAbJ0p20jDB9usxvKAwAAAAAAAAAAAEAAAAAAAAAhLRA20yBDtGpgKf6ob5qZYOJUkLqsqx/Ht8yv16DYJ+qb0DqZ0rdCliI+foeKFlEF7tSc5ste+RHnrh/LxmXL98J+HgBTctf7apFFbxBoauVuggGydKdtIwwfbrMbygMAAAAAAAAAAABAAAAAAAAAIS0QNtMgQ7RqYCn+qG+amWDiVJC6rKsfx7fMr9eg2Cfqm9A6mdK3QpYiPn6HihZRBe7UnObLXvkR564fy8Zly/fCfh4AU3LX+2qRRW8QaGrlboIBsnSnbSMMH26zG8oDAAAAAAAAAAADAAAAAAAAAABAgMEBQYHCAkKAQIDBAUGBwgJCgECAwQFBgcICQoBAgAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=="
"StartValue": "BgAAAAAAAAAcAAAAjAAAAJQAAACVAQAA5QIAAAEAAAAAAAAAsHYm/q4noQwTr1qWt4VHO9r+bkKLz2/M4N8A93372b2pnep8ml6fxeWZt62b22ITElOVZ9CQPruL3OzKbx8CKT5oaMlQqUcQ8LwzhtsD7gQWgR343xC+HmpUW34u+oVhAwAAAAAAAAADAAAAAAAAAAQAAADsAAAADEhxAAAAAAAAAAAAAAAAAAECAwQFBgcICQoBAgMEBQYHCAkKAQIDBAUGBwgJCgECAAAAAAAAAAABAgMEBQYHCAkKAQIDBAUGBwgJCgECAwQFBgcICQoBAgEAAAAAAAAAAQIDBAUGBwgJCgECAwQFBgcICQoBAgMEBQYHCAkKAQIAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABAQAAAAAAAACEtEDbTIEO0amAp/qhvmplg4lSQuqyrH8e3zK/XoNgn6pvQOpnSt0KWIj5+h4oWUQXu1Jzmy175EeeuH8vGZcv3wn4eAFNy1/tqkUVvEGhq5W6CAbJ0p20jDB9usxvKAwAAAAAAAAAAAEAAAAAAAAAl/GuVlfcXjaMtFNct5HhTdKF96NTdvR/bk3UaVQcs9JXNTO1ZXr3Hj/ATXdoxsHjF/QXtqZMrogwa12Ma6tyj/CZ4/RepXXoAJ9zhBlxPKQCxy3gGn8kVpBEDHZO1Fs0AQAAAAAAAAABAAAAAAAAAIt2j34mg8iYmlL93GYLqk6HGmKWLGpngtX1q9bYHwRtYvcHbSnz7sQTqwFApR1GhgzGIIEJfFKoss2X1l46hDL+on7/vNB6/hcM0PVXiqHXIr13sCsGkk5kS+L0CePhwAIAAAAAAAAADAAAAAAAAAABAgMEBQYHCAkKAQIDBAUGBwgJCgECAwQFBgcICQoBAgAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAwAAAAAAAAAAQIDBAUGBwgJCgECAwQFBgcICQoBAgMEBQYHCAkKAQIBAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAMAAAAAAAAAAECAwQFBgcICQoBAgMEBQYHCAkKAQIDBAUGBwgJCgECAgAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"
},
"DecidedValue": "BgAAAAAAAAAcAAAAjAAAAJQAAACVAQAA5QIAAAEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAwAAAAAAAAADAAAAAAAAAAQAAADsAAAADEhxAAAAAAAAAAAAAAAAAAECAwQFBgcICQoBAgMEBQYHCAkKAQIDBAUGBwgJCgECAAAAAAAAAAABAgMEBQYHCAkKAQIDBAUGBwgJCgECAwQFBgcICQoBAgEAAAAAAAAAAQIDBAUGBwgJCgECAwQFBgcICQoBAgMEBQYHCAkKAQIAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABAQAAAAAAAACxiDO7dUnsM+isQUugAv1FuwlMowC9JFlvBKQ0qJvupGJAHafGuS+zmRvRcWPrYDYEpA6N1ngSZsmQAjRGd2/0KpMT3yago0GEpZDlf6QAPWEML6IU20597EaFkgECmLwAAAAAAAAAAAEAAAAAAAAAkJQ0LJUUZVTfhJ3CD3Ql/KaS2s7ny0Uljd0mSo5ZKYYUaf2j0VZ7lSHLqDGI/9YaDb5tcYDHqW9YENGNswXpFDdyt2bTaKqW03UfmNDOLbn55vJjJXAgiNh/DeUAxnxoAQAAAAAAAAABAAAAAAAAAKf4jOQ+/zqozdLjlXxb6tTiE1P77KxgeaU5jQMBm8Rf98lReFFy3u5w6bxau8jKag8EQenUzJ2nTDESE1f318felTP29FfaST4zFOItVUq3ZhPkabBQ4kav9TmjOAcZfAIAAAAAAAAADAAAAAAAAAABAgMEBQYHCAkKAQIDBAUGBwgJCgECAwQFBgcICQoBAgAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAwAAAAAAAAAAQIDBAUGBwgJCgECAwQFBgcICQoBAgMEBQYHCAkKAQIBAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAMAAAAAAAAAAECAwQFBgcICQoBAgMEBQYHCAkKAQIDBAUGBwgJCgECAgAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA",
"Finished": true,
Expand Down Expand Up @@ -341,8 +351,8 @@
"ValidatorCommitteeIndex": 11,
"ValidatorSyncCommitteeIndices": [
0,
1,
2
129,
257
]
}
]
Expand Down Expand Up @@ -649,7 +659,7 @@
"Msgs": {}
}
},
"StartValue": "BgAAAAAAAAAcAAAAjAAAAJQAAACVAQAA5QIAAAEAAAAAAAAAsHYm/q4noQwTr1qWt4VHO9r+bkKLz2/M4N8A93372b2pnep8ml6fxeWZt62b22ITElOVZ9CQPruL3OzKbx8CKT5oaMlQqUcQ8LwzhtsD7gQWgR343xC+HmpUW34u+oVhAwAAAAAAAAADAAAAAAAAAAQAAADsAAAADEhxAAAAAAAAAAAAAAAAAAECAwQFBgcICQoBAgMEBQYHCAkKAQIDBAUGBwgJCgECAAAAAAAAAAABAgMEBQYHCAkKAQIDBAUGBwgJCgECAwQFBgcICQoBAgEAAAAAAAAAAQIDBAUGBwgJCgECAwQFBgcICQoBAgMEBQYHCAkKAQIAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABAQAAAAAAAACEtEDbTIEO0amAp/qhvmplg4lSQuqyrH8e3zK/XoNgn6pvQOpnSt0KWIj5+h4oWUQXu1Jzmy175EeeuH8vGZcv3wn4eAFNy1/tqkUVvEGhq5W6CAbJ0p20jDB9usxvKAwAAAAAAAAAAAEAAAAAAAAAhLRA20yBDtGpgKf6ob5qZYOJUkLqsqx/Ht8yv16DYJ+qb0DqZ0rdCliI+foeKFlEF7tSc5ste+RHnrh/LxmXL98J+HgBTctf7apFFbxBoauVuggGydKdtIwwfbrMbygMAAAAAAAAAAABAAAAAAAAAIS0QNtMgQ7RqYCn+qG+amWDiVJC6rKsfx7fMr9eg2Cfqm9A6mdK3QpYiPn6HihZRBe7UnObLXvkR564fy8Zly/fCfh4AU3LX+2qRRW8QaGrlboIBsnSnbSMMH26zG8oDAAAAAAAAAAADAAAAAAAAAABAgMEBQYHCAkKAQIDBAUGBwgJCgECAwQFBgcICQoBAgAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=="
"StartValue": "BgAAAAAAAAAcAAAAjAAAAJQAAACVAQAA5QIAAAEAAAAAAAAAsHYm/q4noQwTr1qWt4VHO9r+bkKLz2/M4N8A93372b2pnep8ml6fxeWZt62b22ITElOVZ9CQPruL3OzKbx8CKT5oaMlQqUcQ8LwzhtsD7gQWgR343xC+HmpUW34u+oVhAwAAAAAAAAADAAAAAAAAAAQAAADsAAAADEhxAAAAAAAAAAAAAAAAAAECAwQFBgcICQoBAgMEBQYHCAkKAQIDBAUGBwgJCgECAAAAAAAAAAABAgMEBQYHCAkKAQIDBAUGBwgJCgECAwQFBgcICQoBAgEAAAAAAAAAAQIDBAUGBwgJCgECAwQFBgcICQoBAgMEBQYHCAkKAQIAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABAQAAAAAAAACEtEDbTIEO0amAp/qhvmplg4lSQuqyrH8e3zK/XoNgn6pvQOpnSt0KWIj5+h4oWUQXu1Jzmy175EeeuH8vGZcv3wn4eAFNy1/tqkUVvEGhq5W6CAbJ0p20jDB9usxvKAwAAAAAAAAAAAEAAAAAAAAAl/GuVlfcXjaMtFNct5HhTdKF96NTdvR/bk3UaVQcs9JXNTO1ZXr3Hj/ATXdoxsHjF/QXtqZMrogwa12Ma6tyj/CZ4/RepXXoAJ9zhBlxPKQCxy3gGn8kVpBEDHZO1Fs0AQAAAAAAAAABAAAAAAAAAIt2j34mg8iYmlL93GYLqk6HGmKWLGpngtX1q9bYHwRtYvcHbSnz7sQTqwFApR1GhgzGIIEJfFKoss2X1l46hDL+on7/vNB6/hcM0PVXiqHXIr13sCsGkk5kS+L0CePhwAIAAAAAAAAADAAAAAAAAAABAgMEBQYHCAkKAQIDBAUGBwgJCgECAwQFBgcICQoBAgAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAwAAAAAAAAAAQIDBAUGBwgJCgECAwQFBgcICQoBAgMEBQYHCAkKAQIBAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAMAAAAAAAAAAECAwQFBgcICQoBAgMEBQYHCAkKAQIDBAUGBwgJCgECAgAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"
}
],
"CommitteeMember": {
Expand Down
Loading