Skip to content

preconfs: preconf-commitment duty (initial draft)#2063

Closed
iurii-ssv wants to merge 2 commits intostagefrom
preconfs-preconf-commitment-duty
Closed

preconfs: preconf-commitment duty (initial draft)#2063
iurii-ssv wants to merge 2 commits intostagefrom
preconfs-preconf-commitment-duty

Conversation

@iurii-ssv
Copy link
Contributor

@iurii-ssv iurii-ssv commented Mar 6, 2025

This PR is mostly rebased on #2136 (only last commit in this PR is relevant)

This PR depends on:

Before merging:

  • resolve TODOs

@codecov
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 12.15470% with 159 lines in your changes missing coverage. Please review.

Project coverage is 47.5%. Comparing base (0e50970) to head (2c05fe0).
Report is 3 commits behind head on stage.

Files with missing lines Patch % Lines
commit-boost-api/server.go 0.0% 132 Missing ⚠️
cli/operator/node.go 0.0% 10 Missing ⚠️
operator/validator/controller.go 46.6% 8 Missing ⚠️
ekm/eth_key_manager_signer.go 40.0% 3 Missing ⚠️
message/validation/common_checks.go 75.0% 2 Missing ⚠️
utils/casts/casts.go 0.0% 2 Missing ⚠️
message/validation/message_counts.go 50.0% 1 Missing ⚠️
message/validation/partial_validation.go 75.0% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an interesting question if we want to do it separate like this or as part of the general ssv api?

@iurii-ssv iurii-ssv force-pushed the preconfs-preconf-commitment-duty branch from 4e03a7f to 6bfc8cd Compare April 9, 2025 10:31
@iurii-ssv
Copy link
Contributor Author

iurii-ssv commented Apr 9, 2025

Notes to self:

Rebased onto latest stage but eth2-key-manager and ssv-spec deps now are what we have in stage branch (meaning I need to rebase ssvlabs/ssv-spec#526 and ssvlabs/eth2-key-manager#114 and import these newer versions for code to compile correctly)

to set go.mod dependancies to the correct (latest) versions:

GOSUMDB=off GOPROXY=direct go get github.com/ssvlabs/ssv-spec@testing/preconfs-preconf-commitment-duty
GOSUMDB=off GOPROXY=direct go get github.com/ssvlabs/eth2-key-manager@testing/preconfs-preconf-commitment-duty

and also some basic TODOs left:

  • fix this (concurrent calls seems to result in close of closed channel) - I need to make sure no duplicate duties can be started
close(cRunner.initialized)

@iurii-ssv iurii-ssv force-pushed the preconfs-preconf-commitment-duty branch from 6bfc8cd to d83e3b5 Compare April 9, 2025 12:43
@iurii-ssv
Copy link
Contributor Author

Closing this as "unplanned any time soon"

@iurii-ssv iurii-ssv closed this May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants