Add file:// to self links that don't have a protocol#1472
Draft
jsignell wants to merge 3 commits intostac-utils:mainfrom
Draft
Add file:// to self links that don't have a protocol#1472jsignell wants to merge 3 commits intostac-utils:mainfrom
file:// to self links that don't have a protocol#1472jsignell wants to merge 3 commits intostac-utils:mainfrom
Conversation
Contributor
|
Hey there, let me know if you want me to take on any of the todos above, and if so if I should PR to your branch. No worries if you'd rather just stay heads down! |
Member
Author
Yeah the more I have been thinking about this PR the more I think it should be considered a breaking change and wait until pystac 2.0. Part of the reason why I am leaning that way is because the jsonschema validation does not raise. |
5 tasks
This was referenced Jan 3, 2025
4 tasks
b73ffbc to
7675754
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
file://protocol toselflinks that currently don't have a protocol #1347Description:
Pystac already coerces self links to absolute, so now it adds
file://as well.Notes:
normalize."format": "iri"should be handled, but the Python implementation doesn't seem to validate it very well. For instance this passes:file://protocol. Python 3.13 adds some support topathlibin https://docs.python.org/3/library/pathlib.html#pathlib.Path.from_uriPR Checklist:
scripts/test)