feat!: Implement server role listener#957
Merged
NickLarsenNZ merged 19 commits intomainfrom Jul 4, 2025
Merged
Conversation
BREAKING: CRD changes .spec.clusterConfig.listenerClass to .spec.servers.roleConfig.listenerClass
NickLarsenNZ
commented
Jun 24, 2025
NickLarsenNZ
commented
Jun 24, 2025
NickLarsenNZ
commented
Jun 24, 2025
NickLarsenNZ
commented
Jun 24, 2025
NickLarsenNZ
commented
Jun 24, 2025
Note: This is because it relies on information in the status field
Member
Author
|
Smoke tests pass at least. Once merged, I can run all tests in Jenkins and any failures should be fixable through updated hostames. Alternatively, I can run all tests in Replicated locally. Will update here depending on which way I go. Edit: Running all tests sequentially, locally: stackablectl release install dev
make run-dev
scripts/run-tests --parallel 1 --skip-release |
NickLarsenNZ
commented
Jul 3, 2025
Member
Author
|
See also related issue when exposing This PR doesn't change the behaviour. This is why there are no tests for external listeners. |
Member
Author
|
All tests pass stackablectl release install dev
make run-dev
scripts/run-tests --parallel 1 --skip-release |
maltesander
requested changes
Jul 3, 2025
Member
maltesander
left a comment
There was a problem hiding this comment.
Just nitpicks, LGTM overall!
Co-authored-by: Malte Sander <contact@maltesander.com>
Co-authored-by: Malte Sander <contact@maltesander.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #912
Part of stackabletech/issues#692
BREAKING: CRD changes
.spec.clusterConfig.listenerClassto.spec.servers.roleConfig.listenerClassDefinition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker