fix: Controller not respecting ignore* flags #966

[praddy26]

Problem

Fixes #996: Setting ignoreJobs or ignoreCronJobs in Helm values removes RBAC permissions but Reloader still attempts to access Jobs/CronJobs, causing permission errors.

Solution

Implemented a unified --ignored-workload-types flag that accepts both jobs and cronjobs values (individually or together), replacing the need for separate boolean flags while maintaining backward compatibility.

Key Changes

Core Implementation

• Added new flag: --ignored-workload-types (StringSliceVar) accepting jobs, cronjobs, or both
• Enhanced validation: Added GetIgnoredWorkloadTypesList() function with clear error messages
• Updated configuration: Extended ReloaderOptions struct with WorkloadTypesToIgnore field

Handler Logic

• Modified rolling upgrade logic: Updated ShouldReload to check ignored workload types before processing Jobs/CronJobs
• Conditional processing: Skip workload processing when types are in the ignored list

Helm Integration

• Updated deployment template: Added conditional logic to generate --ignored-workload-types arguments based on existing ignoreJobs/ignoreCronJobs values
• Backward compatibility: Existing values.yaml settings continue to work seamlessly

Testing

• Comprehensive test coverage: Added validation for all input combinations
• Integration tests: Verified flag parsing and business logic
• Build validation: Ensured no regressions in existing functionality

Usage Examples

Command Line

# Ignore only Jobs
--ignored-workload-types=jobs

# Ignore only CronJobs  
--ignored-workload-types=cronjobs

# Ignore both
--ignored-workload-types=jobs,cronjobs

[Felix-Stakater]

Hi! I think this functionality is better suited inside the ShouldReload. From what i can tell we have all the context from the cli args + the resource being referenced so it should be possible to do the check from there.

[Felix-Stakater]

LGTM, thank you for your contribution!

[ryndaniels]

@praddy26 just an FYI - we are running with chart v2.2.3 (which looks like it should have this fix) and we're still getting the permission errors in the logs when ignoreJobs/ignoreCronJobs are set in the chart. Not sure if anyone else is still seeing this as well

[r4j4h]

Can confirm with 2.2.3 we are also seeing this behavior

[praddy26]

@ryndaniels @r4j4h Thanks for flagging this. I will work on it.