Support deserialization for data collections#68
Open
rdnewman wants to merge 3 commits intostas:masterfrom
Open
Support deserialization for data collections#68rdnewman wants to merge 3 commits intostas:masterfrom
rdnewman wants to merge 3 commits intostas:masterfrom
Conversation
rdnewman
commented
Sep 29, 2021
| }, | ||
| second_author: { | ||
| data: nil | ||
|
|
Author
There was a problem hiding this comment.
This deserialization spec is pretty long now and I'm sure it could be DRYed out a fair amount (shared examples look promising though most of the length is specifying the data), but wanted to follow existing convention as it was.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
When deserializing (via JSON::Deserialization, #jsonapi_deserialize.call) a document where :data is an array of resources, it fails because it assumes a single resource. The error occurs on Line 52 of jsonapi.rb/lib/jsonapi/deserialization.rb.
What is the new behavior?
jsonapi_deserialize.call now supports cases where :data is an array. Each element of the array will be deserialized in the same manner as when :data is a single resource. Cases where :data is not an array are unchanged.
Checklist
Please make sure the following requirements are complete:
features)