Open
Conversation
Owner
|
Hey hey, apologies for being late with the reviews here! I have a couple of concerns merging this @lHydra Another bigger concern, is that I'd prefer to leave it up to you (the end-user) to decide how to handle the parsed payload. So if we have to change the api from (which is how it's working now): jsonapi_deserialize(params, only: [:email]).deep_symbolize_keysinto jsonapi_deserialize(params, symbolize_keys: true, only: [:email])I'd prefer to keep things the way these are. I hope this makes sense. Thank you very much for the PR though. I'm happy to discuss such concerns in the issues in future, just to avoid extra work on the PR/code. 🙇 🤗 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
At the moment, the call to the
jsonapi_deserializemethod returns hash with string keysWhat is the new behavior?
Method will provide new option
symbolize_keywhich user can set to true and the returned hash will be with symbolized keysChecklist
Please make sure the following requirements are complete:
features)