Skip to content

[6.x] Replicator Display Fixes #13670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JayGeorge wants to merge 8 commits into
base: 6.x
Choose a base branch
from
+9 −0
Open

[6.x] Replicator Display Fixes #13670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fea0834
Hide the first replicator connector line when the label is hidden
JayGeorge Jan 26, 2026
0e6d50d
Merge branch '6.x' into label-hidden-replicator-adjustments
JayGeorge Feb 2, 2026
917c313
Revert hiding the first replicator connector line when the label is h…
JayGeorge Feb 2, 2026
74e8cbc
When hide display is configured the label should only be visually hid…
JayGeorge Feb 2, 2026
4ef52e0
Hide the first replicator connector line when the label is hidden
JayGeorge Feb 2, 2026
3fba5fa
Merge branch '6.x' into label-hidden-replicator-adjustments
JayGeorge Feb 2, 2026
4d817ad
Add a tooltip for the Hide/Show Label control
JayGeorge Feb 2, 2026
f5dfe77
Capitalise to match the field title
JayGeorge Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions resources/js/components/fieldtypes/FieldDisplayFieldtype.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
size="sm"
:icon="hidden ? 'eye-closed' : 'eye'"
variant="ghost"
v-tooltip="hideDisplayTooltip"
@click="toggleHidden"
/>
</template>
Expand All @@ -34,6 +35,9 @@ export default {
hidden() {
return this.getFieldSettingsValue('hide_display');
},
hideDisplayTooltip() {
return this.hidden ? __('Show Display label') : __('Hide Display Label');
},
},

mounted() {
Expand Down
1 change: 1 addition & 0 deletions resources/js/components/fieldtypes/replicator/Replicator.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
:index="index"
:enabled="canAddSet"
:is-first="index === 0"
:show-connector="!(index === 0 && config.hide_display)"
:loading-set="loadingSet"
@added="addSet"
/>
Expand Down
4 changes: 4 additions & 0 deletions resources/js/components/ui/Publish/Field.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ const shouldShowLabelText = computed(() => !props.config.hide_display);
const shouldShowLabel = computed(
() =>
shouldShowLabelText.value || // Need to see the text
props.config.hide_display || // Need label for accessibility (visually hidden)
isLocked.value || // Need to see the avatar
isSyncable.value, // Need to see the icon
);
Expand Down Expand Up @@ -239,6 +240,9 @@ const fieldtypeComponentEvents = computed(() => ({
{{ __(config.display) }}
</span>
</template>
<template v-else-if="config.hide_display">
<span class="sr-only">{{ __(config.display) }}</span>
</template>
<ui-button size="xs" inset icon="synced" variant="ghost" v-tooltip="__('messages.field_synced_with_origin')" v-if="!isReadOnly && isSyncable" v-show="isSynced" @click="desync" />
<ui-button size="xs" inset icon="unsynced" variant="ghost" v-tooltip="__('messages.field_desynced_from_origin')" v-if="!isReadOnly && isSyncable" v-show="!isSynced" @click="sync" />
</Label>
Expand Down