[download id list] support download id list file from sfp#33
Open
paul-statsig wants to merge 1 commit intomainfrom
Open
[download id list] support download id list file from sfp#33paul-statsig wants to merge 1 commit intomainfrom
paul-statsig wants to merge 1 commit intomainfrom
Conversation
Contributor
|
nit: update pr description |
|
You should make change within private repo |
xinlili-oai
reviewed
Feb 24, 2026
| from decimal import Decimal | ||
| from io import BytesIO | ||
| from urllib.parse import urlparse | ||
| from urllib.parse import urlparse, urljoin |
There was a problem hiding this comment.
You should leverate statsig_options to pass in the url
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.