Loosen user_agent_parser constraint to allow minor updates#33
Open
Pezmc wants to merge 1 commit intostatsig-io:mainfrom
Open
Loosen user_agent_parser constraint to allow minor updates#33Pezmc wants to merge 1 commit intostatsig-io:mainfrom
user_agent_parser constraint to allow minor updates#33Pezmc wants to merge 1 commit intostatsig-io:mainfrom
Conversation
~> 2.18.0 only allows versions >= 2.18.0 and < 2.19.0. This blocks installing user_agent_parser 2.20.x.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
~> 2.18.0allows>= 2.18.0and< 2.19.0, which blocks installinguser_agent_parser2.19+ (e.g. 2.20.x).This PR changes the dependency to
~> 2.18, which allows>= 2.18and< 3.0.That includes 2.20.x while staying within the same major version.
Why
user_agent_parserto 2.20.x.statsigcurrently pins~> 2.18.0, excluding 2.19+.~> 2.18keeps compatibility and permits minor and patch releases.Digging into the git history, it doesn't appear like limiting to patch versions was intentional: 63f853b