fix: Spec Store Error Boundary Reference#37
Open
stephenreid wants to merge 1 commit intostatsig-io:mainfrom
Open
fix: Spec Store Error Boundary Reference#37stephenreid wants to merge 1 commit intostatsig-io:mainfrom
stephenreid wants to merge 1 commit intostatsig-io:mainfrom
Conversation
… this was in the begin/end was not being caught correctly
stephenreid
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a
NoMethodErrorinSpecStoreby correcting an invalid reference to the error boundary. The code was previously attempting to callerr_boundary(a local variable or undefined method) instead of the instance variable@error_boundary.This error occurred when the SDK received a response with an invalid hashed SDK key, but it was likely swallowed or resulted in a crash depending on the surrounding rescue blocks.
Changes
lib/spec_store.rbto use@error_boundary.log_exceptioninstead oferr_boundary.log_exception.test/test_spec_store_error_boundary_usage.rbthat mocks an invalid SDK key response and verifies that the exception is correctly logged to the error boundary endpoint.Test Plan
test_process_specs_logs_to_error_boundary_on_invalid_keyto confirm it now correctly catches theInvalidSDKKeyResponseand logs it via the network.NoMethodError.