Skip to content

use existing json if available #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
h-2 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

use existing json if available #83

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4d8598
use existing json if available
Feb 19, 2026
c04c59c
silence shadow warnings
Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,25 +10,29 @@ set(PROJECT_VERSION_SUFFIX "beta.2602190307")
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED ON)

set(STATSIG_CPP_VERSION "${PROJECT_VERSION}${PROJECT_VERSION_SUFFIX}")
set(STATSIG_CPP_VERSION "${PROJECT_VERSION}-${PROJECT_VERSION_SUFFIX}")
# Wrap the prebuilt dylib as an imported library
file(GLOB STATSIG_SOURCE_FILES "src/*")
add_library(Statsig ${STATSIG_SOURCE_FILES})
target_compile_options(Statsig PRIVATE -Wno-shadow)

# Set include directories
target_include_directories(Statsig PRIVATE
${CMAKE_CURRENT_SOURCE_DIR}/include
)

# External Dependency
include(FetchContent)
FetchContent_Declare(
json
GIT_REPOSITORY https://github.com/nlohmann/json.git
GIT_TAG v3.12.0
)
find_package(nlohmann_json QUIET)
if(NOT nlohmann_json_FOUND)
include(FetchContent)
FetchContent_Declare(
json
GIT_REPOSITORY https://github.com/nlohmann/json.git
GIT_TAG v3.12.0
)

FetchContent_MakeAvailable(json)
FetchContent_MakeAvailable(json)
endif()
target_link_libraries(Statsig PUBLIC nlohmann_json::nlohmann_json)

# Check if we should use local build file
Expand Down Expand Up @@ -75,9 +79,9 @@ function (detect_os_target os_target_var library_suffix_var)
set(${library_suffix_var} "so" PARENT_SCOPE)
detect_is_musl(_is_musl)
if(_is_musl)
set(${os_target_var} "linux-musl" PARENT_SCOPE)
set(${os_target_var} "unknown-linux-musl" PARENT_SCOPE)
Copy link
Author

@h-2 h-2 Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why your assets contain the additional "unknown-" prefix, but this at least makes CMake find it.

else()
set(${os_target_var} "linux-gnu" PARENT_SCOPE)
set(${os_target_var} "unknown-linux-gnu" PARENT_SCOPE)
endif()
else()
message(FATAL_ERROR "Unsupported OS: ${os_name}, Contact Statsig support to add support for it")
Expand Down