Add support for overriding param stores#20
Add support for overriding param stores#20rosscooperman wants to merge 1 commit intostatsig-io:mainfrom
Conversation
|
Param stores seemed like the perfect thing to reference from the app until I noticed they couldn't be overridden locally. It would be nice if this got integrated into the SDK. |
|
Any thoughts @andre-statsig? Would really love to get this merged at some point so I can stop referencing my branch. |
|
Hey @rosscooperman, sorry for not seeing this earlier. I'll take a look |
No worries, thanks for looking! |
Merges in #20 - adds `Statsig.overrideParamStore` --------- Co-authored-by: Ross Cooperman <ross@wequilt.com> Co-authored-by: Andre Terron <andre@statsig.com>
|
Hey @rosscooperman, this has been released on 1.52.0! Thank you so much for such a detailed pull request, really appreciate it! Because of our CI setup, we merged a mirror PR on our private repo. Seems like your commit wasn't linked to your GitHub username (the same thing happened on this PR). Is your GitHub profile missing your work email by any chance? I'll try updating our CI to make sure it supports PRs merged on our public repos. Thanks again for contributing to Statsig's iOS SDK! |
|
@andre-statsig thanks! work email is ross@allstar.gg if you're able to update the contribution info. it should be on my gh profile but i'll check |
3 participants
Even if setting overrides for the underlying refs worked (which it doesn't seem to) the whole point of parameter stores is that the client isn't supposed to have to know where the value actually comes from.
This adds support for overriding a parameter store. It does this by creating a param store for the override with exclusively static refs.