Don't unlock the task if lock_expiry is still valid#51
Open
aguedob wants to merge 1 commit intosteinitzu:masterfrom
Open
Don't unlock the task if lock_expiry is still valid#51aguedob wants to merge 1 commit intosteinitzu:masterfrom
aguedob wants to merge 1 commit intosteinitzu:masterfrom
Conversation
Owner
|
I would rather add a new parameter for this so it's not such a dramatic change in behaviour. E.g. |
Owner
|
Possibly even separate params: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
In my use case I need the task result to be cached until the lock time expires, in order to avoid new tasks with the same input data.
Does it make sense to you keeping the lock even if the task has finished?