feat(calendar): add --send-updates flag to update command#176
Open
ejc3 wants to merge 1 commit intosteipete:mainfrom
Open
feat(calendar): add --send-updates flag to update command#176ejc3 wants to merge 1 commit intosteipete:mainfrom
ejc3 wants to merge 1 commit intosteipete:mainfrom
Conversation
The update command was missing the sendUpdates parameter that exists in the Google Calendar API. This meant attendees wouldn't receive notification emails when events were rescheduled. This change: - Adds SendUpdates field to CalendarUpdateCmd struct - Validates the parameter using existing validateSendUpdates() - Passes sendUpdates to Events.Patch() API call Fixes steipete#175
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
updatecommand was missing thesendUpdatesparameter that exists in the Google Calendar API. This meant attendees wouldn't receive notification emails when events were rescheduled.Changes
SendUpdatesfield toCalendarUpdateCmdstructvalidateSendUpdates()sendUpdatestoEvents.Patch()API callUsage
Google Calendar API Reference
The Events: update endpoint supports the
sendUpdatesquery parameter with values:all,externalOnly,none.Fixes #175