Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request attempts to update the Core Advancement Proposals (CAP) table in the README by adding line numbers and protocol versions for three CAP entries (CAP-0074, CAP-0075, and CAP-0076). However, there are critical errors in the protocol version assignments.
Changes:
- Added table row numbers (85, 86, 87) for CAP-0074, CAP-0075, and CAP-0076
- Added protocol versions to these three CAP entries
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | [CAP-0075](cap-0075.md) | Cryptographic Primitives for Poseidon/Poseidon2 Hash Functions | Jay Geng | Awaiting Decision | | ||
| | [CAP-0076](cap-0076.md) | P23 State Archival bug remediation | Dmytro Kozhevin | Final | | ||
| | [CAP-0074](cap-0074.md) | 25 | Host functions for BN254 | Siddharth Suresh | Awaiting Decision | | ||
| | [CAP-0075](cap-0075.md) | 25 | Cryptographic Primitives for Poseidon/Poseidon2 Hash Functions | Jay Geng | Awaiting Decision | |
There was a problem hiding this comment.
The protocol version for CAP-0075 should be 24, not 25. The CAP file (cap-0075.md line 13) specifies "Protocol version: 24".
Suggested change
| | [CAP-0075](cap-0075.md) | 25 | Cryptographic Primitives for Poseidon/Poseidon2 Hash Functions | Jay Geng | Awaiting Decision | | |
| | [CAP-0075](cap-0075.md) | 24 | Cryptographic Primitives for Poseidon/Poseidon2 Hash Functions | Jay Geng | Awaiting Decision | |
| | [CAP-0074](cap-0074.md) | Host functions for BN254 | Siddharth Suresh | Awaiting Decision | | ||
| | [CAP-0075](cap-0075.md) | Cryptographic Primitives for Poseidon/Poseidon2 Hash Functions | Jay Geng | Awaiting Decision | | ||
| | [CAP-0076](cap-0076.md) | P23 State Archival bug remediation | Dmytro Kozhevin | Final | | ||
| | [CAP-0074](cap-0074.md) | 25 | Host functions for BN254 | Siddharth Suresh | Awaiting Decision | |
There was a problem hiding this comment.
The protocol version for CAP-0074 should be 24, not 25. The CAP file (cap-0074.md line 13) specifies "Protocol version: 24".
Suggested change
| | [CAP-0074](cap-0074.md) | 25 | Host functions for BN254 | Siddharth Suresh | Awaiting Decision | | |
| | [CAP-0074](cap-0074.md) | 24 | Host functions for BN254 | Siddharth Suresh | Awaiting Decision | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.