fix(dep): use factory.NewFromConfig for cross-rig dependency resolution#1488
Merged
steveyegge merged 1 commit intosteveyegge:mainfrom Feb 5, 2026
Merged
Conversation
resolveExternalDependencies() hardcoded SQLite storage when resolving cross-rig dependencies, failing silently when the target rig uses Dolt. Now uses factory.NewFromConfig() which reads metadata.json to determine the correct backend (SQLite, Dolt embedded, or Dolt server mode). Fixes steveyegge#1374 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
aleiby
added a commit
to aleiby/beads
that referenced
this pull request
Feb 4, 2026
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
4 tasks
steveyegge
approved these changes
Feb 5, 2026
Owner
steveyegge
left a comment
steveyegge
left a comment
There was a problem hiding this comment.
LGTM - small, targeted fix replacing hardcoded sqlite.New() with factory.NewFromConfig() for cross-rig dependency resolution with Dolt backend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveExternalDependencies()incmd/bd/dep.gohardcodes SQLite storage when resolving cross-rig dependencies via routing. This fails silently when the target rig uses Dolt backend.Changes
sqlite.New()withfactory.NewFromConfig()which readsmetadata.jsonto auto-detect the correct backend (SQLite, Dolt embedded, or Dolt server mode)targetBeadsDirinstead of removedtargetDBPathvariableImpact
bd dep listnow correctly resolves external dependencies for Dolt-backed rigsgt convoy statuswill show accurate counts for convoys tracking cross-rig issuesFixes #1374
🤖 Tackled with Claude Code