fix: generate_config.sh appends config, breaking it on 2nd run. Fix #173#178
Open
gparent wants to merge 1 commit intostoatchat:mainfrom
Open
fix: generate_config.sh appends config, breaking it on 2nd run. Fix #173#178gparent wants to merge 1 commit intostoatchat:mainfrom
gparent wants to merge 1 commit intostoatchat:mainfrom
Conversation
…toatchat#173 Signed-off-by: gparent <370905+gparent@users.noreply.github.com>
gparent
force-pushed
the
generate-config-appends
branch
from
9454607 to
efec389
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think overwriting the file is a big deal since my understanding is the project doesn't ship with a default config.
I know this seems silly but it has broken the set up of more than 1 user (arguably, our fault for not looking at the config afterwards, but still...)