[ACM Obs bot] Bump stolostron/thanos to v0.41.0#330
[ACM Obs bot] Bump stolostron/thanos to v0.41.0#330acm-observability-bot[bot] wants to merge 422 commits intostolostron:release-2.17from
Conversation
Signed-off-by: Saumya Shah <saumyabshah90@gmail.com>
Refactor this check into a separate function so that defer would run at the end of it and clean up resources properly. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
qfe: defer properly
Let's avoid using all the Cortex roundtripper machinery by using the downstream roundtripper directly and then close the body immediately as to not allocate any memory for the body of the response. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Refactor this check into a separate function so that defer would run at the end of it and clean up resources properly. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
docs: update changed repositories links in docs/ to correct location
Release 0.39.1
Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Merge release-0.39 to main
…nos-io#8287) We add a "service_config" field to endpoint config file that we can use to override the default service_config for endpoint groups. This enables us to configure retry policy or loadbalncing on an endpoint level. Signed-off-by: Michael Hoffmann <mhoffmann@cloudflare.com>
Use Prometheus consts instead of using our own. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
*: use prometheus consts
Signed-off-by: Joel Verezhak <j.verezhak@gmail.com>
Signed-off-by: Joel Verezhak <jverezhak@open-systems.com>
Signed-off-by: Joel Verezhak <jverezhak@open-systems.com>
Signed-off-by: Joel Verezhak <jverezhak@open-systems.com>
Signed-off-by: Joel Verezhak <jverezhak@open-systems.com>
Signed-off-by: Joel Verezhak <jverezhak@open-systems.com>
Signed-off-by: Joel Verezhak <jverezhak@open-systems.com>
…nfig fix: query announced endpoints match relabel-config
Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
…tion-flag feat: ignore parquet migrated blocks in store gateway
Thanos Query crashes with "concurrent map iteration and map write" panic in distributed mode when multiple goroutines access the same `annotations.Annotations` map concurrently. ``` panic: concurrent map iteration and map write github.com/prometheus/prometheus/util/annotations.(*Annotations).Merge(...) github.com/thanos-io/promql-engine/engine.(*compatibilityQuery).Exec(...) ``` Here I replaced direct access to `res.Warnings.AsErrors()` with a thread-safe copy: ```go // Before (unsafe) warnings = append(warnings, res.Warnings.AsErrors()...) // After (thread-safe) safeWarnings := annotations.New().Merge(res.Warnings) warnings = append(warnings, safeWarnings.AsErrors()...) ``` Signed-off-by: Joel Verezhak <jverezhak@open-systems.com> Co-authored-by: Joel Verezhak <jverezhak@open-systems.com>
Signed-off-by: Michael Hoffmann <mhoffmann@cloudflare.com>
Signed-off-by: Michael Hoffmann <mhoffmann@cloudflare.com>
Thanos Query crashes with "concurrent map iteration and map write" panic in distributed mode when multiple goroutines access the same `annotations.Annotations` map concurrently. ``` panic: concurrent map iteration and map write github.com/prometheus/prometheus/util/annotations.(*Annotations).Merge(...) github.com/thanos-io/promql-engine/engine.(*compatibilityQuery).Exec(...) ``` Here I replaced direct access to `res.Warnings.AsErrors()` with a thread-safe copy: ```go // Before (unsafe) warnings = append(warnings, res.Warnings.AsErrors()...) // After (thread-safe) safeWarnings := annotations.New().Merge(res.Warnings) warnings = append(warnings, safeWarnings.AsErrors()...) ``` Signed-off-by: Joel Verezhak <jverezhak@open-systems.com> Co-authored-by: Joel Verezhak <jverezhak@open-systems.com> Signed-off-by: Michael Hoffmann <mhoffmann@cloudflare.com>
…d-code receive: remove dead code
receive: make shuffle sharding stable on scale
"Update" spawns multiple concurrent writers all trying to acquire the write mutex for the different endpoints we are updating. If concurrently we serve two "GetEndpointStatus" calls we might end up in a situation where "GetEndpointStatus" A blocks "Update" for some endpoint with a read lock, now Update is a blocked writer and blocks "GetEndpointStatus" B from acquiring another read lock, resulting in a deadlock. Signed-off-by: Michael Hoffmann <mhoffmann@cloudflare.com>
…ntset-race query: fix race in endpointset status vs update
Signed-off-by: Michael Hoffmann <mhoffmann@cloudflare.com>
…ingestor-only receive: fast path for ingestor only
* upgrade to Prometheus 3.8 Signed-off-by: Ben Ye <benye@amazon.com> * update docs Signed-off-by: Ben Ye <benye@amazon.com> * fix lint and tests Signed-off-by: Ben Ye <benye@amazon.com> * update go sum Signed-off-by: Ben Ye <benye@amazon.com> --------- Signed-off-by: Ben Ye <benye@amazon.com>
…oper-labelset-for-remote-engine query: use proper labelset for fan-out pruning in distributed engine
Signed-off-by: Adam Jasinski <adam.jasinski@vinted.com> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
query: enable Series() batching by default
Signed-off-by: Michael Hoffmann <mhoffmann@cloudflare.com>
…log-for-0-41-0 *: cut changelog for 0.41.0
Signed-off-by: Michael Hoffmann <mhoffmann@cloudflare.com>
…lease-41.0-rc.0 VERSION: cut 0.41.0-rc.0
Signed-off-by: James Geisler <geislerjamesd@gmail.com>
Signed-off-by: Michael Hoffmann <mhoffmann@cloudflare.com>
…lease-41.0-rc.1 VERSION: prepare release-41.0-rc.1
Signed-off-by: Michael Hoffmann <mhoffmann@cloudflare.com>
|
Hi @acm-observability-bot[bot]. Thanks for your PR. I'm waiting for a stolostron member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: acm-observability-bot[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/ok-to-test |
|
/retest-required |
Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>
|
/retest |
|
@acm-observability-bot[bot]: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
This is an automated version bump from CI.
The logs for this run can be found in the syncbot repo actions.
If you wish to perform this manually, execute the following commands from stolostron/thanos repo: