Skip to content

Update dependencies and package structure to support ESM#51

Merged
yannbf merged 2 commits intomainfrom
fix-esm-exports
Jun 12, 2025
Merged

Update dependencies and package structure to support ESM#51
yannbf merged 2 commits intomainfrom
fix-esm-exports

Conversation

@yannbf
Copy link
Member

@yannbf yannbf commented Dec 24, 2024

Closes #49
Relates to storybookjs/storybook#26291

This PR does the following:

  • Replace TSC+Babel with TSUP for building the addon
  • Refactor the library accordingly
  • Stop using require in viteFinal so vite doesn't use CJS
  • Upgrade vite-plugin-istanbul from 3.x to 6.x
  • Adds some tests in the stories to check that coverage exists
📦 Published PR as canary version: 2.0.0--canary.51.dcd0bca.0

✨ Test out this PR locally via:

npm install @storybook/addon-coverage@2.0.0--canary.51.dcd0bca.0
# or 
yarn add @storybook/addon-coverage@2.0.0--canary.51.dcd0bca.0

@yannbf yannbf added the major Increment the major version when merged label Dec 24, 2024
@yannbf yannbf self-assigned this Dec 24, 2024
@yannbf yannbf requested a review from kasperpeulen as a code owner December 24, 2024 14:23
@Smeky
Copy link

Smeky commented Feb 11, 2025

Is this still waiting for something?

@thefrana
Copy link

I am too looking forward to this PR. Great work!

@kasperpeulen
Copy link

@yannbf I guess we want to merge this?

@Romainpetit
Copy link

Any chance we can get this merged? 🙏

@valentinpalkovic
Copy link
Contributor

@yannbf Can you provide some information of what's necessary to get this merged?

@valentinpalkovic valentinpalkovic moved this from Needs Discussion to Empathy Backlog in Core Team Projects Mar 24, 2025
@valentinpalkovic
Copy link
Contributor

@yannbf Can we get this merged this week?

@yannbf yannbf merged commit e3d1a90 into main Jun 12, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from Empathy Backlog to Done in Core Team Projects Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

major Increment the major version when merged

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Bug] The CJS build of Vite's Node API is deprecated.

6 participants