Update README.md + Add support for Markdown/HTML + Update loop targets#10
Open
sheriffMoose wants to merge 9 commits intostorybookjs:nextfrom
Open
Update README.md + Add support for Markdown/HTML + Update loop targets#10sheriffMoose wants to merge 9 commits intostorybookjs:nextfrom
sheriffMoose wants to merge 9 commits intostorybookjs:nextfrom
Conversation
filter the elements that goes into the loop to work with `Meta` elements only instead of all elements
allows extracting `title` from `.md` & `.html` docs via the `<title></title>` element
add getting started info + more details about the output
missing feature that is supposed to exist as it is being called already in StoryIndexGenerator
sheriffMoose
added
documentation
shilman
reviewed
Jan 26, 2023
Co-authored-by: Michael Shilman <shilman@users.noreply.github.com>
Co-authored-by: Michael Shilman <shilman@users.noreply.github.com>
…/html title processing
|
@sheriffMoose @shilman Hi! Any plan to approve/merge this? Would love to be able to set tags on unattached docs, since i cannot seem to find any other way to do that without this! Thanks! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What Changed
<title>tag.tags(was supposed to be there as it is already being referenced inStoryIndexGenerator.ts.analyzeloop to target onlyMetaelements instead of all elements.How to test
Change Type
maintenancedocumentationminor