-
Notifications
You must be signed in to change notification settings - Fork 87
Prepare for SB10 #569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for SB10 #569
Changes from all commits
a064053
958c7be
fd3c654
b6bd5f6
2094e4b
7fd5891
f4b51e6
49024ff
de6531a
d23885c
2a1e346
8fcb31b
4da85c2
52a3bda
9afc71c
6552af9
d9d46ef
020e626
8609766
f3d1819
9fa10a3
7e6c71c
db60cb3
f437d4a
5cf9d6b
dbc63e2
29f1ef4
d0c3175
2c9779a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,9 @@ | ||
| module.exports = { | ||
| presets: [ | ||
| ['@babel/preset-env', { targets: { node: 'current' } }], | ||
| '@babel/preset-typescript', | ||
| '@babel/preset-react', | ||
| ], | ||
| presets: [['@babel/preset-env', { targets: { node: 'current' } }], '@babel/preset-typescript'], | ||
| env: { | ||
| esm: { | ||
| presets: [ | ||
| [ | ||
| '@babel/preset-env', | ||
| { | ||
| modules: false, | ||
| targets: { node: 'current' }, | ||
| }, | ||
| ], | ||
| ], | ||
| test: { | ||
| presets: ['@babel/preset-typescript'], | ||
| plugins: ['@babel/plugin-transform-modules-commonjs'], | ||
| }, | ||
| }, | ||
| }; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| v18 | ||
| v20.16.0 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,7 +15,11 @@ | |
| "url": "https://github.com/storybookjs/test-runner" | ||
| }, | ||
| "license": "MIT", | ||
| "author": "shilman", | ||
| "author": [ | ||
| "shilman", | ||
| "ndelangen", | ||
| "yannbf" | ||
| ], | ||
| "main": "dist/index.js", | ||
| "module": "dist/index.mjs", | ||
| "types": "dist/index.d.ts", | ||
|
|
@@ -29,7 +33,7 @@ | |
| "*.d.ts" | ||
| ], | ||
| "scripts": { | ||
| "build": "tsup", | ||
| "build": "NODE_ENV=production NODE_OPTIONS='--max-old-space-size=8192' tsup", | ||
| "build-storybook": "storybook build", | ||
| "build:watch": "tsup --watch", | ||
| "generate-dynamic-stories": "node scripts/generate-dynamic-stories.js", | ||
|
|
@@ -51,13 +55,22 @@ | |
| "*.{ts,js,tsx,jsx,css,md}": "prettier --write" | ||
| }, | ||
| "dependencies": { | ||
| "@babel/cli": "^7.12.1", | ||
| "@babel/core": "^7.22.5", | ||
| "@babel/generator": "^7.22.5", | ||
| "@babel/parser": "^7.26.9", | ||
| "@babel/plugin-transform-modules-commonjs": "^7.22.5", | ||
| "@babel/preset-env": "^7.19.4", | ||
| "@babel/preset-react": "^7.18.6", | ||
| "@babel/preset-typescript": "^7.18.6", | ||
| "@babel/template": "^7.22.5", | ||
| "@babel/traverse": "^7.26.9", | ||
| "@babel/types": "^7.22.5", | ||
| "@jest/types": "^29.6.3", | ||
| "@swc/core": "^1.5.22", | ||
| "@swc/jest": "^0.2.23", | ||
| "esbuild": "^0.18.0 || ^0.19.0 || ^0.20.0 || ^0.21.0 || ^0.22.0 || ^0.23.0 || ^0.24.0 || ^0.25.0", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This looks pretty annoying to keep up to date. Is the intention that each time esbuild releases a new version, this will be updated? Why not use
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You're right @IanVS However the version range you mention promises to be compatible with "all future versions" of I think that's a promise that can't be kept.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's fair. Though I think you can use |
||
| "esbuild-register": "^3.6.0", | ||
| "expect-playwright": "^0.8.0", | ||
| "jest": "^29.6.4", | ||
| "jest-circus": "^29.6.4", | ||
|
|
@@ -68,50 +81,106 @@ | |
| "jest-serializer-html": "^7.1.0", | ||
| "jest-watch-typeahead": "^2.0.0", | ||
| "nyc": "^15.1.0", | ||
| "playwright": "^1.14.0" | ||
| "playwright": "^1.14.0", | ||
| "playwright-core": "^1.14.0", | ||
| "semver": "^7.6.2" | ||
| }, | ||
| "devDependencies": { | ||
| "@auto-it/released": "^11.1.6", | ||
| "@aw-web-design/x-default-browser": "1.4.126", | ||
| "@babel/cli": "^7.12.1", | ||
| "@babel/preset-env": "^7.19.4", | ||
| "@babel/preset-react": "^7.18.6", | ||
| "@babel/preset-typescript": "^7.18.6", | ||
| "@storybook/addon-a11y": "next", | ||
| "@storybook/addon-coverage": "^1.0.0", | ||
| "@storybook/addon-docs": "next", | ||
| "@storybook/docs-mdx": "4.0.0-next.1", | ||
| "@storybook/icons": "^1.4.0", | ||
| "@storybook/react-vite": "next", | ||
| "@testing-library/dom": "10.4.0", | ||
| "@testing-library/react": "^14.0.0", | ||
| "@types/cross-spawn": "^6.0.6", | ||
| "@types/detect-port": "^1.3.0", | ||
| "@types/diff": "^5.0.9", | ||
| "@types/ejs": "^3.1.1", | ||
| "@types/find-cache-dir": "^5.0.0", | ||
| "@types/jest": "^29.0.0", | ||
| "@types/js-yaml": "^4.0.5", | ||
| "@types/node": "^16.4.1", | ||
| "@types/node-fetch": "^2.6.11", | ||
| "@types/npmlog": "^7.0.0", | ||
| "@types/picomatch": "^2.3.0", | ||
| "@types/prettier": "^3.0.0", | ||
| "@types/pretty-hrtime": "^1.0.0", | ||
| "@types/semver": "^7.5.8", | ||
| "@vitejs/plugin-react": "^4.0.3", | ||
| "@yarnpkg/esbuild-plugin-pnp": "^3.0.0-rc.10", | ||
| "@yarnpkg/fslib": "2.10.3", | ||
| "@yarnpkg/libzip": "2.3.0", | ||
| "auto": "^11.1.6", | ||
| "babel-jest": "^29.0.0", | ||
| "babel-loader": "^8.1.0", | ||
| "babel-plugin-istanbul": "^6.1.1", | ||
| "browser-dtector": "^3.4.0", | ||
| "bundle-require": "^5.1.0", | ||
| "camelcase": "^8.0.0", | ||
| "can-bind-to-host": "^1.1.1", | ||
| "chai": "^5.1.1", | ||
| "commander": "^9.0.0", | ||
| "comment-parser": "^1.4.1", | ||
| "concurrently": "^7.0.0", | ||
| "cross-spawn": "^7.0.6", | ||
| "diff": "^5.2.0", | ||
| "es-toolkit": "^1.36.0", | ||
| "esbuild": "^0.18.0 || ^0.19.0 || ^0.20.0 || ^0.21.0 || ^0.22.0 || ^0.23.0 || ^0.24.0 || ^0.25.0", | ||
| "find-up": "^5.0.0", | ||
| "glob": "^10.2.2", | ||
| "globby": "^14.0.1", | ||
| "husky": "^8.0.0", | ||
| "jest-image-snapshot": "^6.2.0", | ||
| "js-yaml": "^4.1.0", | ||
| "leven": "^4.0.0", | ||
| "lint-staged": "^13.0.3", | ||
| "mlly": "^1.7.4", | ||
| "nanoid": "^4.0.2", | ||
| "node-fetch": "^2", | ||
| "npmlog": "^7.0.0", | ||
| "open": "^8.4.0", | ||
| "p-limit": "^6.2.0", | ||
| "package-manager-detector": "^1.1.0", | ||
| "picocolors": "^1.1.0", | ||
| "picomatch": "^2.3.0", | ||
| "picoquery": "^1.4.0", | ||
| "pkg-up": "^5.0.0", | ||
| "prettier": "^2.8.1", | ||
| "pretty-hrtime": "^1.0.3", | ||
| "react": "^17.0.1", | ||
| "react-dom": "^17.0.1", | ||
| "read-pkg-up": "^7.0.1", | ||
| "storybook": "next", | ||
| "sirv": "^2.0.4", | ||
| "slash": "^3.0.0", | ||
| "storybook": "^0.0.0-0 || ^8.2.0 || ^9.0.0 || ^9.1.0-0", | ||
| "storybook-src": "git+https://github.com/storybookjs/storybook.git#next", | ||
| "strip-ansi": "^7.1.0", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There are a lot of devDependencies being added here, and they don't all seem to be used. For example, searching for
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I honestly never intentioned this to be the final way we do things. So I performed no cleanup. Though
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not users, but it will have an impact on contributors, since they'll have to download all of these. Not that it's a huge deal, but it's also somewhat confusing to see dependencies that aren't used in a package.json. But I wouldn't want a cleanup to block getting this released. |
||
| "strip-json-comments": "^5.0.1", | ||
| "telejson": "8.0.0", | ||
| "tempy": "^1.0.1", | ||
| "tiny-invariant": "^1.3.1", | ||
| "tinyspy": "^3.0.2", | ||
| "ts-dedent": "^2.0.0", | ||
| "ts-jest": "^29.0.0", | ||
| "tsconfig-paths": "^4.2.0", | ||
| "tsup": "^6.5.0", | ||
| "type-fest": "^4.18.1", | ||
| "typescript": "~4.9.4", | ||
| "unique-string": "^3.0.0", | ||
| "vite": "^6.3.2", | ||
| "wait-on": "^7.2.0" | ||
| "wait-on": "^7.2.0", | ||
| "watchpack": "^2.2.0" | ||
| }, | ||
| "peerDependencies": { | ||
| "storybook": "^0.0.0-0 || ^8.2.0 || ^9.0.0 || ^9.1.0-0 || ^9.2.0-0" | ||
| "storybook": "^0.0.0-0 || ^8.2.0 || ^9.0.0 || ^9.1.0-0 || ^9.2.0-0 || ^10.0.0-0" | ||
| }, | ||
| "engines": { | ||
| "node": ">=20.0.0" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this "the recipe"? 🤔💭❗