Conversation
❌ Deploy Preview for stryker-mutator failed.
|
rouke-broersma
left a comment
There was a problem hiding this comment.
The build seems to be failing because stryker-js has not yet released a new version containing a fix for the links in their docs. Stryker-js needs to release a new version before we can merge this.
Am I correct that the versions.json containing both the stable and preview/unreleased/vnext is not included in this change?
|
Correct. I tried implementing it with multiple versions, but it didn’t really work that well. |
|
As I mentioned in the last PR, I still don't think the feature is a good idea in this state. Stryker-js having broken docs and needing a release is a prime example of it. Yes, we should release frequently. Stryker4s hasn't had a release in two months due to slowed development. But having to create releases just to fix the docs is not a good reason IMO. I would still be in favour of having versioned docs of a few last versions and a "next" version |
This would be difficult to implement as all the stryker frameworks have separate versions. I think multi-instancing docusaurus (https://docusaurus.io/docs/docs-multi-instance) is the way to go here. I am not sure how to implement that though and it would require some more set up in the different repositories. |
I think we should use this instead of always retrieving the
HEAD.Old pull request: #484
Related issue: #345
For the future it might be worth looking at multi-instancing the docs: https://docusaurus.io/docs/docs-multi-instance
That way we could have versioning seperately for each stryker project.