Skip to content

use changed delete hook #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
d10r wants to merge 2 commits into
base: master
Choose a base branch
from
Open

use changed delete hook #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
892d48b
use changed delete hook
d10r Oct 22, 2025
4eedc9f
changed API
d10r Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/superfluid-protocol-monorepo
Open in desktop
Submodule superfluid-protocol-monorepo updated from a5bf3a to 3b138f
36 changes: 13 additions & 23 deletions src/AdSpotContract.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,14 +180,14 @@ contract AdSpotContract is CFASuperAppBase {
ISuperToken,
/*superToken*/
address sender,
int96 flowRate,
bytes calldata ctx
)
internal
override
returns (bytes memory newCtx)
{
int96 senderFlowRate = acceptedToken.getFlowRate(sender, address(this));
require(senderFlowRate > highestFlowRate, "Sender flowrate lower than current flowRate");
require(flowRate > highestFlowRate, "Sender flowrate lower than current flowRate");
newCtx = ctx;
if (highestBidder != address(0)) {
newCtx = acceptedToken.deleteFlowWithCtx(highestBidder, address(this), ctx);
Expand All @@ -200,10 +200,10 @@ contract AdSpotContract is CFASuperAppBase {
pool.updateMemberUnits(highestBidder, halfShares + pool.getUnits(highestBidder));
}
highestBidder = sender;
highestFlowRate = senderFlowRate;
highestFlowRate = flowRate;
lastUpdate = block.timestamp;
emit newHighestBidder(highestBidder, highestFlowRate);
newCtx = acceptedToken.distributeFlowWithCtx(address(this), pool, senderFlowRate, newCtx);
newCtx = acceptedToken.distributeFlowWithCtx(address(this), pool, flowRate, newCtx);
return newCtx;
}

Expand All @@ -219,28 +219,20 @@ contract AdSpotContract is CFASuperAppBase {
function onFlowUpdated(
ISuperToken,
address sender,
int96 previousflowRate,
uint256,
/*lastUpdated*/
int96 flowRate,
int96 previousFlowRate,
uint256 lastUpdated,
bytes calldata ctx
)
internal
override
returns (bytes memory newCtx)
{
int96 senderFlowRate = acceptedToken.getFlowRate(sender, address(this));
require(
senderFlowRate > previousflowRate,
"Sender flowRate is lower than the previous one, delete flowrate and start a new one lower"
);
require(senderFlowRate > highestFlowRate, "You already have a flowrate that is higher than this one");
) internal override returns (bytes memory newCtx) {
require(flowRate > previousFlowRate, "Sender flowRate is lower than the previous one, delete flowrate and start a new one lower");
require(flowRate > highestFlowRate, "You already have a flowrate that is higher than this one");
newCtx = ctx;
uint128 halfShares = SafeCast.toUint128(block.timestamp - lastUpdate) / 2;
ISuperfluidPool(poolAddress).updateMemberUnits(owner, halfShares + pool.getUnits(owner));
ISuperfluidPool(poolAddress).updateMemberUnits(highestBidder, halfShares + pool.getUnits(highestBidder));
newCtx = acceptedToken.distributeFlowWithCtx(address(this), pool, senderFlowRate, newCtx);
newCtx = acceptedToken.distributeFlowWithCtx(address(this), pool, flowRate, newCtx);
highestBidder = sender;
highestFlowRate = senderFlowRate;
highestFlowRate = flowRate;
lastUpdate = block.timestamp;
emit newHighestBidder(highestBidder, highestFlowRate);
return newCtx;
Expand All @@ -254,12 +246,10 @@ contract AdSpotContract is CFASuperAppBase {
* @return bytes Returns the new transaction context.
*/

function onFlowDeleted(
function onInFlowDeleted(
ISuperToken,
/*superToken*/
address sender,
address,
/*receiver*/
int96,
/*previousFlowRate*/
uint256,
Expand Down
Loading