[ETHEREUM-CONTRACTS] Dedicated allowlist contract for SuperApp registration#2083
Merged
[ETHEREUM-CONTRACTS] Dedicated allowlist contract for SuperApp registration#2083
Conversation
Changelog ReminderReminder to update the CHANGELOG.md for any of the modified packages in this PR.
|
hellwolf
reviewed
Jun 30, 2025
hellwolf
reviewed
Jul 1, 2025
packages/ethereum-contracts/contracts/interfaces/superfluid/ISuperfluid.sol
Outdated
Show resolved
Hide resolved
hellwolf
reviewed
Jul 1, 2025
hellwolf
approved these changes
Jul 2, 2025
Contributor
hellwolf
left a comment
hellwolf
left a comment
There was a problem hiding this comment.
old registration method is no longer tested though.
XKCD Comic RelifLink: https://xkcd.com/2083 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & Why
This PR introduces a dedicated simple allowlist contract for managing SuperApp registration permission.
This is done in order to make this rather frequent process more lightweight, as it does not require the same degree of security of other governance actions like contract upgrades.
How
Adds an immutable constructor argument to
Superfluid.solfor the allowlist contract.Extends the precondition for SuperApp registration to first check if permission is given by this allowlist. If not, it also looks up the governance contract, such that pre-existing permissions stay in place.
This solution does not require any changes to the governance contract and only small and very localized changes to the host contract.
Other
The PR also includes some replacements of
registerAppWithKeyandregisterAppByFactorywithregisterAppin mock contracts. This is just cleanup of deprecated logic, not directly related to the changes.