[ETHEREUM-CONTRACTS] remove PoolMemberNFT and remainders of FlowNFTs#2087
Merged
[ETHEREUM-CONTRACTS] remove PoolMemberNFT and remainders of FlowNFTs#2087
Conversation
Changelog ReminderReminder to update the CHANGELOG.md for any of the modified packages in this PR.
|
hellwolf
approved these changes
Jul 16, 2025
XKCD Comic RelifLink: https://xkcd.com/2087 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & Why
PoolMemberNFTs were deprecated in v1.13.0..
That release contains a last logic update of that contract.
This follow-up PR removes a lot of code nomore needed afterwards.
Note that
SuperTokenFactoryfor now needs to keep a reference toPOOL_ADMIN_NFT_LOGICbecause theupdateCodeof the deployed instances requires the new logic to have it. Only in a consecutive update can that be pruned too from the contract and from the deploy script.The PR also contains such pruning for the FlowNFTs where this step was already applied.