Skip to content

fix: multiple typos of different importance #2095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
crStiv wants to merge 6 commits into from
Closed

fix: multiple typos of different importance #2095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a8264c0
Update VestingSchedulerV2.sol
crStiv Jul 27, 2025
0d29e7a
Update VestingSchedulerV3.sol
crStiv Jul 27, 2025
1588c53
Update FlowScheduler.t.sol
crStiv Jul 27, 2025
7935a0e
Update InstantDistributionAgreementV1-Non-Callback.test.ts
crStiv Jul 27, 2025
027a203
Update FlowSchedulerResolver.t.sol
crStiv Jul 27, 2025
2ab51c9
Update VestingSchedulerV2.t.sol
crStiv Jul 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/automation-contracts/scheduler/contracts/VestingSchedulerV2.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ contract VestingSchedulerV2 is IVestingSchedulerV2, SuperAppBase {
if (!disableClaimCheck && schedule.claimValidityDate != 0)
revert ScheduleNotClaimed();

// Ensure that the claming date is after the cliff/flow date and before the claim validity date
// Ensure that the claiming date is after the cliff/flow date and before the claim validity date
if (schedule.cliffAndFlowDate > block.timestamp ||
_lteDateToExecuteCliffAndFlow(schedule) < block.timestamp)
revert TimeWindowInvalid();
Expand Down
4 changes: 2 additions & 2 deletions packages/automation-contracts/scheduler/contracts/VestingSchedulerV3.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ using SuperTokenV1Library for ISuperToken;
* The contract uses ERC-20 allowance and Superfluid ACL flow operator permissions
* to automate the vesting on behalf of the sender.
* The contract is designed to be used with an off-chain automation to execute the vesting start and end.
* The start and end executions are permisionless.
* The start and end executions are permissionless.
* Execution delays are handled with token transfer compensations, but watch out for complete expiries!
* @custom:metadata The official addresses and subgraphs can be found from @superfluid-finance/metadata package.
*/
Expand Down Expand Up @@ -760,7 +760,7 @@ contract VestingSchedulerV3 is IVestingSchedulerV3, IRelayRecipient {
revert ScheduleNotClaimed();
}

// Ensure that the claming date is after the cliff/flow date and before the claim validity date
// Ensure that the claiming date is after the cliff/flow date and before the claim validity date
if (schedule.cliffAndFlowDate > block.timestamp || _lteDateToExecuteCliffAndFlow(schedule) < block.timestamp) {
revert TimeWindowInvalid();
}
Expand Down
2 changes: 1 addition & 1 deletion packages/automation-contracts/scheduler/test/FlowScheduler.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ contract FlowSchedulerTest is FoundrySuperfluidTester {
bytes userData
);

/// @dev This is required by solidity for using the SupertTokenV1Library in the tester
/// @dev This is required by solidity for using the SuperTokenV1Library in the tester
using SuperTokenV1Library for SuperToken;
constructor() FoundrySuperfluidTester(3) {}
FlowScheduler internal flowScheduler;
Expand Down
2 changes: 1 addition & 1 deletion packages/automation-contracts/scheduler/test/FlowSchedulerResolver.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ contract FlowSchedulerResolverTest is FoundrySuperfluidTester {
expectUnexecutable();
}

function testDeleteNonExistantStreamAfterEndDate() public {
function testDeleteNonExistentStreamAfterEndDate() public {
vm.startPrank(alice);

uint32 defaultEndDate = defaultStartDate + uint32(3600);
Expand Down
2 changes: 1 addition & 1 deletion packages/automation-contracts/scheduler/test/VestingSchedulerV2.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2418,7 +2418,7 @@ contract VestingSchedulerV2Tests is FoundrySuperfluidTester {

uint32 newEndDate = type(uint32).max - 1234;

// Setting up a batch call. Superfluid Protocol will replace the emtpy context with data about the sender. That's where the sender is retrieved from.
// Setting up a batch call. Superfluid Protocol will replace the empty context with data about the sender. That's where the sender is retrieved from.
ISuperfluid.Operation[] memory ops = new ISuperfluid.Operation[](1);
ops[0] = ISuperfluid.Operation({
operationType: BatchOperation.OPERATION_TYPE_SUPERFLUID_CALL_APP_ACTION,
Expand Down
2 changes: 1 addition & 1 deletion ...m-contracts/test/contracts/agreements/InstantDistributionAgreementV1-Non-Callback.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ describe("IDAv1 | Non-Callback Tests", function () {
);
});

it("#1.1.3 publisher should fail to query non-existant index", async () => {
it("#1.1.3 publisher should fail to query non-existent index", async () => {
const idata = await t.contracts.ida.getIndex(
superToken.address,
alice,
Expand Down