[AUTOMATION] deploy autowrap with burned owner keys, switch to hardhat-verify#2104
[AUTOMATION] deploy autowrap with burned owner keys, switch to hardhat-verify#2104
Conversation
…etherscan v2 api support
Changelog ReminderReminder to update the CHANGELOG.md for any of the modified packages in this PR.
|
There was a problem hiding this comment.
This was simplified (inlined into the deploy script) because if burning the owner keys, there's no future path for adding more strategies.
| "hardhat": "^2.22.9", | ||
| "hardhat-deploy": "^0.12.4", | ||
| "hardhat": "^2.26.1", | ||
| "hardhat-deploy": "^1.0.4", |
There was a problem hiding this comment.
The switch from v0 to v1 did not come with API breakage according to the changelog
| "eslint-plugin-prettier": "^5.2.1", | ||
| "hardhat": "^2.22.9", | ||
| "hardhat-deploy": "^0.12.4", | ||
| "hardhat": "^2.26.1", |
There was a problem hiding this comment.
this implies dropped node18 support. But with ethereum-contracts already having dropped that, should be ok.
| "@nomicfoundation/hardhat-ethers": "^3.0.7", | ||
| "@nomiclabs/hardhat-etherscan": "^3.1.7", | ||
| "@nomiclabs/hardhat-web3": "^2.0.0", | ||
| "@nomicfoundation/hardhat-ethers": "^3.1.0", |
There was a problem hiding this comment.
hardhat-ethers v3 requires hardhat v2 and ethers v6.
There's also hardhat-ethers v4, but it requires hardhat v3.
ethereum-contracts package still uses ethers v5, thus has an overriding import of hardhat-ethers v2 which depends on ethers v5.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
d10r
requested review from
hellwolf,
kasparkallas and
vmichalik
as code owners
d10r
changed the title
| @@ -11,7 +11,6 @@ | |||
| ./autowrap/package.json | |||
| ./autowrap/contracts | |||
| ./autowrap/test | |||
There was a problem hiding this comment.
what about ./deploy/deploy.js
There was a problem hiding this comment.
my understanding here is that the nix env is only used for building and testing (with foundry), while deploy.js is a hardhat based deploy script. Is that correct or should deploy.js be included (anyway)?
There was a problem hiding this comment.
okay, if deploy.js is not used in testing flow, then it's not required.
XKCD Comic RelifLink: https://xkcd.com/2104 |
3 participants
Autowrap: call
renounceOwnership()after deployment.metadata update of new autowrap deployment on Base
Replaced @nomiclabs/hardhat-etherscan with @nomicfoundation/hardhat-verify for etherscan v2 compatibility.
Since the v1 etherscan API key becomes defunct anyway, the env vars for v2 api keys was renamed to
ETHERSCAN_API_V2_KEY.Also updated all hardhat related packages to the latest version compatible with hardhat v2 and ethers v5.