[ETHEREUM-CONTRACTS] 1.14.1: pool and pseudo-event patch

[d10r]

• fix and test coverage of pool authentication
• prevent revert of pseudo-transfer-event invocation on SuperTokens not upgraded to the latest logic
• update foundry to 1.3.6
• update truffle verification plugin to support etherscan v2 api

[github-actions]

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

• CHANGELOG.md modified
• Double check before merge

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[hellwolf]

1. Finish the TODOs in the GDA contract.
2. Do not emit pseudo transfer in Pool; leave it in the CFA.

[d10r]

tried to add modifiers for all TODOs, but goes above contract size limit. Found out after doing a small refactoring for solving a "stack too deep". Would be better code, but the Solidity and EVM constraints don't (yet) allow it.
I suggest we leave the TODOs in place.

[d10r]

Decided to postpone conversion to modifiers, we're already too close to Solidity (stack too deep) & EVM (contract size limit) constraints with this contract.
Instead there's now more detailed inline commenting, also in some places we now have more rigorous argument checks which reduce the risk of introducing vulnerabilities with future logic changes.

I suggest to release it like this.

[hellwolf]

okay, let me do a few small clean up and merge some other PR fragments (from community, but not with signed commits.)

[github-actions]

XKCD Comic Relif

Link: https://xkcd.com/2121