Skip to content

Sync: refactor save results#623

Open
heushreck wants to merge 2 commits intomainfrom
sync-from-hosted-1770135667
Open

Sync: refactor save results#623
heushreck wants to merge 2 commits intomainfrom
sync-from-hosted-1770135667

Conversation

@heushreck
Copy link
Contributor

Auto-synced from hosted repository

Original PR: https://github.com/superglue-ai/superglue-hosted/pull/286
Author: @stefanfaistenauer
Merged by: @stefanfaistenauer


Summary by cubic

Refactored run results storage to run at completion via RunLifecycleManager and switched storage availability checks to the FileService. This decouples the flow from Postgres and makes storage backend-agnostic.

  • Refactors
    • Moved results storage from PostgresService to RunLifecycleManager, storing results asynchronously, updating resultStorageUri via datastore.updateRun, and no longer persisting full result payloads in the DB.
    • Replaced S3-specific isS3StorageAvailable with isFileStorageAvailable in FileService; removed the old check.
    • Updated GET /runs/:runId/results to use the new availability check and a clearer error message.
    • Removed run results storage triggers and org preference checks from PostgresService.
    • Clarified shared type comments to reference FileService instead of S3.
    • Adjusted Next.js types import path in web/next-env.d.ts.

Written for commit 9ced996be27815d369484eddff1038a1561b95ce. Summary will update on new commits.


⚠️ Note: Hosted-only files (ee/, supabase/, scheduler/, discovery/, etc.) have been automatically excluded from this sync.

stefanfaistenauer and others added 2 commits February 3, 2026 16:21
* refactoring of the save results flow

* linting

* fix tests
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants