Skip to content

Sync: masking fixes#644

Open
heushreck wants to merge 1 commit intomainfrom
sync-from-hosted-1770658278
Open

Sync: masking fixes#644
heushreck wants to merge 1 commit intomainfrom
sync-from-hosted-1770658278

Conversation

@heushreck
Copy link
Contributor

Auto-synced from hosted repository

Original PR: https://github.com/superglue-ai/superglue-hosted/pull/312
Author: @michaelfuest
Merged by: @michaelfuest


Summary by cubic

Centralizes and fixes credential masking, and removes the Edit System diff UI to prevent exposing sensitive values. Applies consistent masking across system fetches and agent helpers, plus a minor Next.js types path fix.

  • Bug Fixes
    • Added shared maskSystemCredentials and isSensitiveCredentialKey with a non-sensitive allowlist (e.g., client_id, host, region); masks all other credential keys.
    • filterSystemFields now uses maskSystemCredentials; runFindSystem returns masked systems (single and list).
    • Removed change diff rendering from EditSystemComponent to avoid leaking secrets; keeps simple status + system ID.
    • Updated Next.js routes types import to .next/dev/types/routes.d.ts.

Written for commit 85d54f81be14e5b6351c9fb7f1329408e9fb8798. Summary will update on new commits.


⚠️ Note: Hosted-only files (ee/, supabase/, scheduler/, discovery/, etc.) have been automatically excluded from this sync.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants