Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR applies "ALL" ruff linting rules across the codebase and fixes the resulting linting issues. Key changes include reformatting function signatures and parameter lists, adding trailing commas, updating ignore rules in pyproject.toml, and minor documentation adjustments.
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/raglite/_split_chunklets.py | Adjusted numpy.asarray formatting for better style compliance. |
| src/raglite/_search.py | Reformatted function arguments and list comprehensions; added trailing commas. |
| src/raglite/_rag.py | Updated parameter formatting and added type annotations. |
| src/raglite/_query_adapter.py | Updated tqdm parameter formatting and ruff ignore comment. |
| src/raglite/_mcp.py | Minor trailing comma and formatting changes. |
| src/raglite/_markdown.py | Improved list formatting with trailing commas. |
| src/raglite/_litellm.py | Added missing type annotations and trailing commas. |
| src/raglite/_lazy_llama.py | Added return type annotations and adjusted inline comments. |
| src/raglite/_insert.py | Reformatted function calls and parameter ordering. |
| src/raglite/_extract.py | Updated comment annotations and trailing commas. |
| src/raglite/_eval.py | Reformatted parameters and added commas for consistency. |
| src/raglite/_embed.py | Adjusted multi-line argument formatting and trailing commas. |
| src/raglite/_database.py | Reformatted init functions and added inline noqa comments. |
| src/raglite/_config.py | Updated parameter formatting for consistency. |
| src/raglite/_cli.py | Reformatted CLI option ordering and comments. |
| src/raglite/_chatml_function_calling.py | Adjusted inline comments and parameter formatting. |
| src/raglite/_chainlit.py | Minor formatting changes for consistency. |
| src/raglite/_bench.py | Reformatted constructor methods and property definitions. |
| src/raglite/init.py | Adjusted all declaration with inline noqa comment. |
| pyproject.toml | Updated ruff configuration to select "ALL" rules and appropriate ignores. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
"ALL"ruff rules, modulo a minimal set of exceptions.