feat: Make the terminal on tutorials resizable with SplitPane#1741
Open
bricefrisco wants to merge 8 commits intosveltejs:mainfrom
Open
feat: Make the terminal on tutorials resizable with SplitPane#1741bricefrisco wants to merge 8 commits intosveltejs:mainfrom
bricefrisco wants to merge 8 commits intosveltejs:mainfrom
Conversation
|
@bricefrisco is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Looked into this more, the styling can be simplified because the It looks like it was meant to create a top fade / depth separator between the terminal and whatever is above it, but that will now be done by Also no need to set the <SplitPane
min="50px"
type="vertical"
disabled={!terminal_visible}
max={terminal_visible ? '80%' : '100%'}
pos={terminal_visible ? '20%' : '100%'}
>As I was going along, I stumbled upon and decided to quickly fix #624 by increasing the opacity on the background. With the terminal in the after photo being resizable as well. I'm pushing those changes now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Closes #1740 by wrapping the viewer and terminal in a SplitPane.
Quick demo:
screen-capture.webm
Update (see comments): Fixes #624