Skip to content

[stdlib] Generalize the filter(_:) functions for typed throws #87020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
glessard wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[stdlib] Generalize the filter(_:) functions for typed throws #87020

glessard wants to merge 10 commits into from
+212 −67

Conversation

@glessard
Copy link
Contributor

@glessard glessard commented Feb 6, 2026 •
edited
Loading

Generalizes the filter(_:) functions of most standard library types to support typed throws.

@glessard
Copy link
Contributor Author

glessard commented Feb 6, 2026

@swift-ci please test

@glessard glessard force-pushed the filter-closures-typed-throws branch from dd5fcf3 to 9cee83d Compare February 6, 2026 06:41
@glessard
Copy link
Contributor Author

glessard commented Feb 6, 2026

@swift-ci please test

@glessard glessard force-pushed the filter-closures-typed-throws branch from 9cee83d to eaf1713 Compare February 6, 2026 23:09
@glessard
Copy link
Contributor Author

glessard commented Feb 6, 2026

@swift-ci please test macOS platform

@glessard glessard force-pushed the filter-closures-typed-throws branch from eaf1713 to 31970af Compare February 7, 2026 20:19
@glessard
Copy link
Contributor Author

glessard commented Feb 7, 2026

@swift-ci please test

@glessard
Copy link
Contributor Author

glessard commented Feb 7, 2026

@swift-ci Please Test Source Compatibility

@glessard glessard force-pushed the filter-closures-typed-throws branch from 31970af to 733f7bd Compare February 8, 2026 00:54
@glessard
Copy link
Contributor Author

glessard commented Feb 8, 2026

@swift-ci please test

@glessard
Copy link
Contributor Author

glessard commented Feb 9, 2026

@swift-ci please test macOS platform

@glessard
Copy link
Contributor Author

glessard commented Feb 9, 2026

@swift-ci Please Test Source Compatibility

@glessard
Copy link
Contributor Author

glessard commented Feb 9, 2026

@swift-ci please test Linux platform

@glessard glessard force-pushed the filter-closures-typed-throws branch from 733f7bd to 1dea0bf Compare February 9, 2026 19:21
@glessard
Copy link
Contributor Author

glessard commented Feb 9, 2026

@swift-ci please test

@glessard glessard force-pushed the filter-closures-typed-throws branch from 1dea0bf to 5b5e892 Compare February 9, 2026 21:14
@glessard
Copy link
Contributor Author

glessard commented Feb 9, 2026

@swift-ci please test

@glessard glessard force-pushed the filter-closures-typed-throws branch from 5b5e892 to c624d59 Compare February 10, 2026 02:33
@glessard glessard mentioned this pull request Feb 10, 2026
Open
@glessard
Copy link
Contributor Author

glessard commented Feb 10, 2026

Please test with following PR: swiftlang/sourcekit-lsp#2479

@swift-ci please test

@glessard
Copy link
Contributor Author

glessard commented Feb 10, 2026

Please test with following PR: swiftlang/sourcekit-lsp#2479

@swift-ci please smoke test

@glessard glessard mentioned this pull request Feb 10, 2026
Open
@glessard glessard marked this pull request as ready for review February 10, 2026 21:55
@glessard glessard requested review from a team, hborla, slavapestov and xedin as code owners February 10, 2026 21:55
glessard
glessard commented Feb 10, 2026
View reviewed changes
validation-test/Sema/type_checker_perf/fast/rdar36838495.swift
@@ -1,4 +1,4 @@
// RUN: %target-typecheck-verify-swift -solver-scope-threshold=2000
// RUN: %target-typecheck-verify-swift -solver-scope-threshold=2400
Copy link
Contributor Author

@glessard glessard Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also keep the old performance of this test; see #87122
What would the type checker gurus prefer?

Copy link
Contributor Author

@glessard glessard Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After consulting with Slava, we'll have both versions.

@glessard
Copy link
Contributor Author

glessard commented Feb 10, 2026

Please test with following PR: swiftlang/sourcekit-lsp#2479

@swift-ci please test

@glessard
Copy link
Contributor Author

glessard commented Feb 11, 2026

Please test with following PR: swiftlang/sourcekit-lsp#2479

@swift-ci please test Windows platform

@glessard
Copy link
Contributor Author

glessard commented Feb 11, 2026

@swift-ci Please Test Source Compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@glessard @clintonpi